[1.9.4] World transformer has incorrect method name reference for non-obsfucated..

Question

[1.9.4] World transformer has incorrect method name reference for non-obsfucated..

OreCruncher opened this issue 8 years ago · 4 comments

OreCruncher commented 8 years ago

Here is the link. "getBiomeGenForCoords" is incorrect - should be "getBiome". Explains that nasty exception I get when running in my IDE. :)

(I have TAN as a library in my sandbox so I can build against it. However I can't run a debug session because of the transform error.)

EDIT: I should state that I am working with Minecraft Forge 1.10.2-12.18.3.2185

Adubbz · Answer 1 · 2016-12-27T03:23:58.000Z

Odd, I had to fix this for 1.11 but I don't recall it being a problem when updating to 1.9.4... In any case, I've pushed a commit to fix it. I won't bother making a new release though since it's only really relevant for the development environment

OreCruncher · Answer 2 · 2016-12-27T05:40:01.000Z

Thanks! Picked up the changes in a local sandbox and it works well. Is there a forum that you frequent where I can post questions?

…

On Mon, Dec 26, 2016 at 7:23 PM, Adubbz ***@***.***> wrote: Odd, I had to fix this for 1.11 but I don't recall it being a problem when updating to 1.9.4... In any case, I've pushed a commit to fix it. I won't bother making a new release though since it's only really relevant for the development environment — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#159 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGGS70mWNiAZ1HndEN5caYxuqYbnyFkVks5rMITPgaJpZM4LV_Pa> .

Adubbz · Answer 3 · 2016-12-27T05:43:50.000Z

Generally Discord is the best place https://discordapp.com/invite/0loJvLMgvZi0q596 (There's also a client for it too if you dislike the browser version)

p455w0rd · Answer 4 · 2017-01-04T04:08:40.000Z

a direct clone of the 1.9.4 branch fails due to this 'fix' because this is a 1.10.2 change

Share to