Touhou Little Maid

Touhou Little Maid

Mods
2M Downloads

[Bug] Maids' voices pack issue - Idle voice lines are included in the list for other actions.

Revv1e opened this issue ยท 2 comments

commented

Minecraft Version

  • 1.12.2 (End of support)
  • 1.16.5 (End of support)
  • 1.18.2
  • 1.19.2
  • 1.20/1.20.1
  • 1.21/1.21.1

What happened?

  1. Add voice pack
  2. Check Maid Sound Pack
  3. Notice that when you preview idle voice lines, they also are included in the voice lines for other actions, like farming, feeding, and such.

image

I made a copy of the peco voice lines and removed everything except the idle and farm voices, idle has 60 and farm has 6, and then when i check, the idle voice lines are also in all other action voice lines.

I believe the expected result is that only the 6 voice lines for farm should appear in the farm voice list, and the same with other actions. Otherwise it just gets weird unexpected voice lines

Relevant log output

No response

Contact Details

No response

commented

For the record the sound.json file in the resources only has farm1 and idle1, so not even that is being read properly, unless I am doing something wrong, which I very well could be.

commented

After taking a look at the code, CustomSoundLoader.java has the lines where IDLE is being reused for the rest of the actions....any chance we could have a way to toggle that on or off maybe? Or removing those lines?