Registering pools during worldgen seems to cause Minecraft to complain about "missing" pools
TelepathicGrunt opened this issue · 8 comments
I was running my mod Blame with Towers of the Wild and it found several tower pieces weren't actually spawning. Here's all the pieces it found summarized. Hopefully this helps! :
****************** Blame Report 1.7.3 ******************
Empty template pool found from : towers_of_the_wild:regular_bottom
The path represented by this is: data/towers_of_the_wild/worldgen/template_pool/regular_bottom
The structure piece with a Jigsaw Block that is targeting an empty pool is: towers_of_the_wild:regular/tower_top
Empty template pool found from : towers_of_the_wild:jungle_bottom
The path represented by this is: data/towers_of_the_wild/worldgen/template_pool/jungle_bottom
The structure piece with a Jigsaw Block that is targeting an empty pool is: towers_of_the_wild:jungle/jungle_tower_top
Empty template pool found from : towers_of_the_wild:derelict_top
The path represented by this is: data/towers_of_the_wild/worldgen/template_pool/derelict_top
The structure piece with a Jigsaw Block that is targeting an empty pool is: towers_of_the_wild:derelict/derelict_tower_bottom
Empty template pool found from : towers_of_the_wild:ice_bottom
The path represented by this is: data/towers_of_the_wild/worldgen/template_pool/ice_bottom
The structure piece with a Jigsaw Block that is targeting an empty pool is: towers_of_the_wild:ice/ice_tower_top
Empty template pool found from : towers_of_the_wild:ocean_bottom
The path represented by this is: data/towers_of_the_wild/worldgen/template_pool/ocean_bottom
The structure piece with a Jigsaw Block that is targeting an empty pool is: towers_of_the_wild:ocean/ocean_tower_top
Empty template pool found from : towers_of_the_wild:ocean_warm_bottom
The path represented by this is: data/towers_of_the_wild/worldgen/template_pool/ocean_warm_bottom
The structure piece with a Jigsaw Block that is targeting an empty pool is: towers_of_the_wild:ocean_warm/ocean_warm_tower_top
Empty template pool found from : towers_of_the_wild:derelict_bottom
The path represented by this is: data/towers_of_the_wild/worldgen/template_pool/derelict_bottom
The structure piece with a Jigsaw Block that is targeting an empty pool is: towers_of_the_wild:derelict/derelict_tower_top
Most common cause is that there is a typo in this path to the template pool which then points to a non-existent pool.
Please let the mod author know about this so they can double check the path to make sure it is correct.
log:
latest.log
I seemed to fix this with without using datapacks. See #8
I need to mention that even if you remove the mod, the jigsaw issue still happens. I hope my fix will solve this.
Looks like the tower do spawn their pieces but minecraft keeps complaining about missing pools. Like this:
[22Dec2020 00:16:49.479] [Worker-Main-15/WARN] [net.minecraft.world.gen.feature.jigsaw.JigsawManager/]: Empty or none existent pool: towers_of_the_wild:derelict_bottom
Though it seems the pool down exist as it is registered here but mcinecraft might be throwing a fit the first time it attempts to grab the pool before it actually sees it.
Maybe switch the pools from being in code to using vanilla's worldgen json like this?
https://github.com/TelepathicGrunt/RepurposedStructures/blob/master/src/main/resources/data/repurposed_structures/worldgen/template_pool/temples/pyramid_badlands.json
Or maybe try initializing your pools at mod startup instead of during worldgen. In fact, doing it at startup is a better idea so that your coded pools won't registry replace people's datapack attempt to override the tower pools to add new pieces.
I am seeing this issue, and it causes the game to hang. I have to kill the process if it happens.
Using the latest version of the mod keeps throwing this...
****************** Blame Report 1.9.2 ******************
Empty template pool found from : towers_of_the_wild:regular_bottom
The path represented by this is: data/towers_of_the_wild/worldgen/template_pool/regular_bottom
The structure piece with a Jigsaw Block that is targeting an empty pool is: towers_of_the_wild:regular/tower_top
Most common cause is that there is a typo in this path to the template pool which then points to a non-existent pool.
Please let the mod author know about this so they can double check the path to make sure it is correct.
@ldrae Sorry for the ping, but this issue seems to be causing lag in Enigmatica 6, could you please have a look if you haven't already? :)
jigsaw blocks pointing to a missing pool shouldn't ever really cause lag. I would check other mods instead or try removing mods see which could be the cause