Bug description

using trade cycling in conjuction with visible traders causes this to happen:

when cycling, the visible trades dont show and you have to close out of the villager and open again, it is more of a minor inconvenience than anything and it doesnt really bother me but i thought it might have been worth reporting anyways (i will open an issue on visible traders github too)

Minecraft version

1.21.1

Mod version

1.21.1-1.0.15

Mod loader and version

Fabric Loader 0.16.10

Steps to reproduce

1. use visible traders and trade cycling mods together
2. click on a villager with a job
3. his other trades can be seen until you cycle, then they dissapear until you exit out the villager then right click it again

Expected behavior

No response

Log files

https://gist.github.com/thiswebsiteiscancer/b8df5619c37a3c4129e8865f973671f7

Screenshots

No response

If @'henkelmax is interested in compatibility, I can add a method for Trade Cycling to call that will generate the remaining trades at the cost of a possible performance hit since trade generation was not optimized to be called consecutively

If @'henkelmax is interested in compatibility, I can add a method for Trade Cycling to call that will generate the remaining trades at the cost of a possible performance hit since trade generation was not optimized to be called consecutively

Yeah that would be awesome. I haven't yet taken a look at it but what I can see from the video, technically reopening the GUI should do the same, but I think this might have some other implications.

Visible Traders generates a level's worth of trades every tick to spread the trade generation lag out. Reopening the GUI would work, but either Trade Cycling would have to wait 15 or so ticks to give time for loading or Trade Cycling would need to detect if the trades have updated and then send an update packet to the client. Unless you'd prefer this, I can get started on the compat on my end

Ok, yeah waiting would feel weird for the player. Yeah a compatibility method would be awesome, thanks!

V:0.0.7 has been pushed with the compat method. To use it, you'll need to cast your VillagerEntity to my duck interface VillagerDuck and call the method visibleTraders$forceTradeGeneration(). Let me know if you run into complications

Perfect, thanks a lot!

i appreciate you guys taking your time looking into this, i honestly didnt expect it since its such a minor thing but thanks a lot anyways

@Ramixin, your method does not seem to work. After calling visibleTraders$forceTradeGeneration(), .visibleTraders$getLockedOffers() returns an empty list.

Btw you can DM me on Discord. The name is henkelmax.