Trading Post [Forge & Fabric]

Trading Post [Forge & Fabric]

12M Downloads

Exp dup; coming out of both table and villager

GraySloth opened this issue ยท 3 comments

commented

Bug description
When making a trade the table produces Exp, but the villager that does the trade also does as well. This seems like it's doubling the amount of Exp you get from trades.

Steps to reproduce the issue

Use a Trading Post
Make a trade
Both table and Villager produce exp

Expected behavior
When making a trade at the Post either exp is produced from the Post or the villager but not both.

Versions

Minecraft version 1.16.5
Forge version 36.2.34
Mod version
    Trading Post: 1.0.2
commented

Yeah that feature is a bit cheesy since i need to delete the xp orbs dropped at the villager. It was working fine during testing, but maybe another mod is interfering.
I'll see if I can redo that logic so that xp is only teleported, so there is no chance for it to duplicate.

commented

Are you really getting xp twice? The code does not seem to permit this logically speaking. All xp orbs spawned at the villager are collected and for every one that was found a new one is spawned at the table and the old one is deleted. But this really only happens when the original orbs are found.
So I'm pretty certain if you're seeing xp twice it's a client desync issue, and the xp appearing at the villager is not actually there (your xp value shouldn't increase when trying to collect it).

commented

Clumps mod might be as it messes with xp orbs spawning in.

But maybe the best idea is to disable xp being teleported at all in the server config for now.