Trash Cans

Trash Cans

17M Downloads

[Bug] Ceramic bucket get converted to an iron bucket

benbenlaw opened this issue · 6 comments

commented

Version Info

  • Minecraft, 1.16.5
  • Trash Cans, 1.0.9

Description of the Bug
Gives a iron bucket in a fluid trash can in stead on a ceramic one when those buckets are used

Steps to Reproduce
install https://www.curseforge.com/minecraft/mc-mods/ceramic-bucket

Screenshots
image
image

commented

Yes, it's because I check if it's an instance of the BucketItem class and not the actual bucket item.

if(this.liquidItem.getItem() instanceof BucketItem)

commented

Doesn't the vanilla bucket have also a FluidHandler?

commented

I think, this line causes this issue:

this.liquidItem = new ItemStack(Items.BUCKET);

commented

Yes indeed, only the water bottle doesn't, so no clue why I didn't just use that.

commented

haha at least you found it

commented

I fixed the issue now in version 1.0.10.

Thanks to you all for reporting the issue and helping out!