Trash Cans

Trash Cans

17M Downloads

[Feature-1.16.5] gas trash can

EnterFor opened this issue · 8 comments

commented

Is your feature request related to a problem? Please describe.
I hope you add a gas trash can, it will be very useful.

Describe the solution you'd like
I hope you add a gas trash can, it will be very useful.

commented

The liquid trash can can already filter and void gasses. I don't think adding it as a separate block will be very useful.

commented

In my test, gas cannot enter the trash can
Test using gas in MEK

commented

I can void gasses just fine when testing.
What exactly are you trying to do?

commented

This line should probably be changed to:

if (!ChemicalAttributeValidator.process(gasStack, ChemicalAttributeValidator.DEFAULT))
    return false;

to ensure that any of our gases that require special compat cannot be voided, not just ones with radiation. I believe radiation is the only one that currently is marked as needing special handling/validation, but still...

commented

if you mean Mekanism, the mod already has its own way to dump his gasses, just set the gas tank to "dump"

commented

No I meant:
What did @EnterFor try, to test if the gas trash can works?

For me gas can just be voided using the liquid trash can, so I don't see an issue.

commented

I'm sorry for the late reply.
Yes, nuclear waste can't go into the trash can when I test it.

commented

@pupnewfster thanks I will change that!

@EnterFor I guess this issue can be closed then?