Traveler's Backpack [Fabric]

Traveler's Backpack [Fabric]

15M Downloads

[1.20.1] Blaze Backpack crash when hit with blaze fireball

treacherousfiend opened this issue ยท 4 comments

commented
  1. ALWAYS PROVIDE INFORMATION ABOUT MODLOADER (Fabric / Forge) AND MOD VERSION (For Example 1.19.2-8.2.10)
    Forge 1.20.1 (running through NeoForged, if it matters)
    Traveler's Backpack 9.1.33 (slightly outdated, but the code for the blaze backpack does not appear to be changed since then)

  2. Describe the bug
    Same issue as #1101 and #778, getting hit with a blaze's fireball while wearing the Blaze Backpack causes the game to crash.
    This appears to have been fixed in most, but not all branches.
    The 1.20.1 branch appears to be the only one that still has the event.setImpactResult code that appears to be the cause of this issue, and is also on a version of minecraft where the mod still gets updated.
    Other branches such as 1.21-Forge and 1.20.4 also have this bug, but they don't appear to be supported anymore.
    1.20.1-dev appears to have fixed this issue, but the change never got merged into the main branch.

  3. Write steps to reproduce the bug
    -Wear Blaze Backpack
    -Get hit by Blaze's fireball

  4. What is expected behaviour
    Game will not crash.

  5. Screenshots (If applicable)

commented

Well, the problem is that:

  • latest forge provides said method
  • neoforge does not have this method

If you'd be using only forge it would work fine, but you use NeoForge

commented

Makes sense, testing in latest forge on 1.20.1 does fix it.
Is this the kind of thing that you would be willing to "fix" for 1.20.1 or should I just permanently swap over to Forge for this version of minecraft?
I had installed NeoForge through Prism Launcher, and I'm noticing now that NeoForge doesn't even seem to support 1.20.1, with the first versions they have on their websites being for 1.20.2, so I'm not entirely sure where the heck this version of NeoForge is coming from, especially since it seems to be still following the Forge version numbers

commented

I'll try my best to find middle ground and make it work with both forge and neoforge, will update in the next week