Traveler's Backpack [Fabric]

Traveler's Backpack [Fabric]

Mods
11M Downloads

Incompatability with Sleep Tight (1.19.2)

Mrbysco opened this issue ยท 1 comments

commented

  1. ALWAYS PROVIDE INFORMATION ABOUT MODLOADER (Fabric / Forge) AND MOD VERSION (For Example 1.19.2-8.2.10)
    Minecraft 1.19.2
    Forge 43.2.21
    Travelers Backpack 1.19.2-8.2.30
    Sleep Tight 1.19.2-1.0.22
    Moonlight Lib 1.19.2-2.2.44-forge

  2. Describe the bug
    Incompatability with Sleep Tight on servers

  3. Write steps to reproduce the bug
    Sleep in a Travelers Baackpack sleeping bag. Add 16000 to the time and try to sleep again. Get kicked for null component.

  4. What is expected behaviour
    Being told by Sleep Tight that you aren't tired yet.

  5. Screenshots (If applicable)
    image

  6. Question
    There's a missing null check that the vanilla bed has.

    Travelers-Backpack/src/main/java/com/tiviacz/travelersbackpack/blocks/SleepingBagBlock.java

    Line 143 in e47d551

    if(p_49477_ != null)

    In the vanilla bedblock that'd be if(p_49477_.getMessage() != null)
    Is there a reason for extracting the startSleepInBed method from the player classes into the SleepingBagBlock btw?