Duping and deleting items when using Easy Shulker Boxes Mod
luigi-pennacchio08 opened this issue · 16 comments
-
ALWAYS PROVIDE INFORMATION ABOUT MODLOADER (Fabric / Forge) AND MOD VERSION (For Example 1.19.2-8.2.10)
Fabric 0.16.9
Minecraft 1.21.1
Traveler's Backpack 10.1.6
Easy Shulker Boxes v21.1.0 -
Describe the bug
im using the latest version of the mod but i have this strange bug (see the videos) when combined with easy shulker boxes mod
i made the same bug report to easy shulker boxes mod but no response yet -
Write steps to reproduce the bug
use traveler's backpack mod and easy shulker boxes together
put a shulker box in any backpack and equip it
put any item in the shulker box while wearing the backpack
place the backpack on the ground
click on the backpack and grab the item from the shulker and put the item on your inventory
equip the backpack and look at shulker contents, the item should be duplicated -
What is expected behaviour
the items get duplicated or deleted while grabbing a item from a shulker inside a backpack -
Screenshots (If applicable)
the items just get duplicated
https://github.com/user-attachments/assets/43fc86b7-d0a6-4406-aa33-afa9304ed4ab
here the items just get deleted
https://github.com/user-attachments/assets/332731a3-cc22-4a95-b697-f02bde7a5e7f
I think this issue should be solved by fix from easy shulkerboxes. It seems like when esb is modifing shulkerbox contents, the method that is responsible for detecting changes inside inventory is not called, which causes duplication issues. I guess that's happening because esb is altering contents in a wrong way.
I tried to look at esb code, but haven't found anything that could help, so its up to the other dev.
Update. I discovered that this bug also happens with vanilla bundles, so this might be on tb's side?
It seems like it might be issue that should be patched by modloader? Im not sure. The point is that the inventory is not getting called changed when something is being put in shulker/bundle and it definitely should indicate that contents changed.
This bug only happens in newer versions of traveler's backpack, it never happened in older versions.
allowShulkerBoxes set to false, it will prevent putting shulkerboxes inside backpack until I come up with fix
allowShulkerBoxes set to false, it will prevent putting shulkerboxes inside backpack until I come up with fix
Ok I can try that or I can just disable right-click unequip backpack.
From my tests contents sometimes were duplicated even without taking backpack off, its problem strictly with saving so Id suggest to disable shulkeboxes in backpack
From my tests contents sometimes were duplicated even without taking backpack off, its problem strictly with saving so Id suggest to disable shulkeboxes in backpack
Weird, I'll' patiently wait for the fix.
I'm focused on releasing update for neoforge at the moment, I haven't touched fabric yet so no updates
I've got fix for the issue, but still I'm going to release NeoForge/Forge updates first so Fabric has to wait a bit
I'm focused on releasing update for neoforge at the moment, I haven't touched fabric yet so no updates
Okay no worries