Traveler's Backpack

Traveler's Backpack

39M Downloads

Abnormal internet usage or packet size on the server

UnnamedWei opened this issue · 24 comments

commented
  1. ALWAYS PROVIDE INFORMATION ABOUT MODLOADER (Fabric / Forge) AND MOD VERSION (For Example 1.19.2-8.2.10)
    Fabric 1.20.1
    Mod version 9.1.31

  2. Describe the bug
    Abnormal internet usage spikes on the server, even when there is not a lot players online.

It happened when I updated the mod from 9.1.23 to 9.1.31

Image

commented

No I don’t use the trinkets integration. But I think yes we use the default mechanic (Equip by the button in the backpack)

commented

also it happens all the time or just when you join

commented

it was fine before?

Yes it only happened after we updated the mod, and there is also a feature like creating backup for backpack when player died so tried to turn it off but there is no configuration for it

commented

also it happens all the time or just when you join

Seems like all the time, not only increased the average usage but also causing spikes

commented

it was fine before?

Yes it only happened after we updated the mod, and there is also a feature like creating backup for backpack when player died so tried to turn it off but there is no configuration for it

Why would you need to turn it off?

Anything changed when you updated the mod in your backpack: like you added any upgrades or something

commented

it was fine before?

Yes it only happened after we updated the mod, and there is also a feature like creating backup for backpack when player died so tried to turn it off but there is no configuration for it

Why would you need to turn it off?

Anything changed when you updated the mod in your backpack: like you added any upgrades or something

I thought this feature is causing the usage so I tried to turn it off, not 100% sure what it does.
I am not sure what do you mean by the last part.

commented

Backup works only when player dies, it creates copy of backpack equipped and saves to the file

I mean: when you updated the mod, did you afterwards add any upgrades to backpack? added items to backpack etc.

commented

Backup works only when player dies, it creates copy of backpack equipped and saves to the file

I mean: when you updated the mod, did you afterwards add any upgrades to backpack? added items to backpack etc.

Hmmm, could you please make an example or tell me the reason for asking this? I am still confused, after we updated the mod we didn’t change anything about the mod itself, just normally using backpacks

commented

I mean:
Lets say you had your backpack before update with some items inside + crafting and tanks upgrade
And then after update (.31 adds furnace upgrades)
Lets say you've added furnace and smoker upgrades to your backpack and started using them

commented

And you've updated only Traveler's Backpack, no other mods were updated?

commented

I mean: Lets say you had your backpack before update with some items inside + crafting and tanks upgrade And then after update (.31 adds furnace upgrades) Lets say you've added furnace and smoker upgrades to your backpack and started using them

No we didn’t, most upgrades have a duplication bug with the money in the numismatic-overhaul mod so we banned them before anyone can use them

commented

Also do you use trinkets integration? or default equip by button in backpack inventory mechanic

commented

And you've updated only Traveler's Backpack, no other mods were updated?

We also updated the Puzzlelibs but it doesn’t involve any network changing, I am reporting this because I heard there are other servers using this mod encountered same issue

commented

it was fine before?

commented

any update?

commented

Okay, I will setup server myself quickly and check

commented

I've launched the server, you said that you use no upgrades, equipped the backpack (cow backpack to check ability too) and filled backpack with some shulkerboxes full of fireworks (that are heavy on data) and didnt encounter any higher network traffic.
The only higher network traffic was noticed when generating the terrain, so when I was walking around and thats okay I think
Does unequipping the backpack resolve your problem?

commented

有什么更新吗?

Maybe it requires more players? I will try to find more informations, thank you for testing it, could you please also double check the network related codes just in case? Thanks!

commented

I'm curious if it's possible for you to unequip the backpack and see what's the result, the only higher network traffic I've encountered was noticable when 2nd player was spamming swapping tools, but like I said - spamming, with normal usage the network traffic was correct

commented

I'm curious if it's possible for you to unequip the backpack and see what's the result, the only higher network traffic I've encountered was noticable when 2nd player was spamming swapping tools, but like I said - spamming, with normal usage the network traffic was correct

There is too much player to control, I am currently researching on another bug, maybe puzzlelibs caused this too, if confimed can be fixed I will close this, thanks!

commented

I also encountered the same problem in 9.1.31 of 1.20.1 fabric

commented

I also encountered the same problem in 9.1.31 of 1.20.1 fabric

Could you provide steps to reproduce this? What I have to do to encounter high network traffic

commented

Any update on this issue?

commented

Any update on this issue?

Not yet, so maybe I will close this for now, thanks