Traveler's Backpack

Traveler's Backpack

39M Downloads

[Mod Compatability] Stack Overflow when player hits Create package while wearing Bee Backpack

JoshEvans-Weber opened this issue ยท 2 comments

commented
  1. ALWAYS PROVIDE INFORMATION ABOUT MODLOADER (Fabric / Forge) AND MOD VERSION (For Example 1.19.2-8.2.10)
    NEOFORGE 21.1.19

  2. Describe the bug
    When the player hits a Create Mod package with the bee backpack equipped the server and client crash with stack overflow error

at TRANSFORMER/[email protected]/com.simibubi.create.content.logistics.box.PackageEntity.hurt(PackageEntity.java:302) ~[create-1.21.1-6.0.6.jar%23490!/:6.0.6] {re:classloading}
at TRANSFORMER/[email protected]/com.tiviacz.travelersbackpack.common.BackpackAbilities.beeAbility(BackpackAbilities.java:636) ~[travelersbackpack-neoforge-1.21.1-10.1.22.jar%23671!/:?] {re:mixin,re:classloading}
at TRANSFORMER/[email protected]/com.tiviacz.travelersbackpack.handlers.NeoForgeEventHandler.onHit(NeoForgeEventHandler.java:316) ~[travelersbackpack-neoforge-1.21.1-10.1.22.jar%23671!/:?] {re:classloading}
at MC-BOOTSTRAP/net.neoforged.bus/net.neoforged.bus.SubscribeEventListener.invoke(SubscribeEventListener.java:50) ~[bus-8.0.5.jar%23154!/:?] {}
at MC-BOOTSTRAP/net.neoforged.bus/net.neoforged.bus.EventBus.post(EventBus.java:360) ~[bus-8.0.5.jar%23154!/:?] {}
at MC-BOOTSTRAP/net.neoforged.bus/net.neoforged.bus.EventBus.post(EventBus.java:328) ~[bus-8.0.5.jar%23154!/:?] {}
at TRANSFORMER/[email protected]/net.neoforged.neoforge.common.CommonHooks.onPlayerAttackTarget(CommonHooks.java:762) ~[neoforge-21.1.193-universal.jar%23443!/:?] {re:classloading}
at TRANSFORMER/[email protected]/com.simibubi.create.content.logistics.box.PackageEntity.hurt(PackageEntity.java:302) ~[create-1.21.1-6.0.6.jar%23490!/:6.0.6] {re:classloading}

  1. Write steps to reproduce the bug
    Install Travelors Backpack and Create Mod 6.x and create a package, place it into the world, equip bee backpack and hit the package

  2. What is expected behaviour
    Create mod package should break without error thrown from bee backpack ability

commented

I can provide workaround for this, but this is Create devs thing to fix it properly, they are calling the event in the method that is already getting called by the same event, and it's causing infinite loop. Please report it to them if you can