Traveler's Backpack

Traveler's Backpack

32M Downloads

Fluid tanks - Tooltip and Config

Unleashed75 opened this issue ยท 2 comments

commented
  1. ALWAYS PROVIDE INFORMATION ABOUT MODLOADER (Fabric / Forge) AND MOD VERSION (For Example 1.19.2-8.2.10)

  2. Describe the bug
    Placing buckets inside of a tank shows the wrong values in the tool tip.
    The config values for "tanksCapacity" does not work as expect and can stop servers from loading and stop buckets from being emptied.

Putting 1 bucket into a tank does not increase by 1000mB each time on the tooltip but as 81000
Changing the config values to be whole buckets like in the image below, 2000, 3000, 4000 etc just breaks things even more where a server will not load and in a single player world, buckets will not empty into the tanks.

  1. Write steps to reproduce the bug
    Fresh new profile, Install the latest mods to play on 1.20.1 Fabric;
  • fabric-loader-0.15.6-1.20.1
  • fabric-api-0.91.0+1.20.1
  • travelers-backpack-1.20.1-9.1.9
  • cloth-config-11.1.118-fabric
  • cardinal-components-api-5.2.2

Open a new world and give yourself a backpack and place a bucket into one of the tanks. Use your mouse to see how much is inside the tank.

  1. What is expected behaviour
    I expected to see the number of buckets in the tank shown in the tooltip as whole buckets or as mB.
    I expected to be able to change the values in config so that I could custom set each tier to hold a value I set.

  2. Screenshots (If applicable)

Default config settings for "tanksCapacity";
image

How things look when using default config;
image

After changing config to this;
image

Buckets no longer empty.
(note; this is single player world because my server will not load with these settings);
image

commented

as you can see one bucket equals 81000, that's because fabric uses different measurements for fluids than forge.
forge 1000 = fabric 81000

if you want to store 1 bucket less = 162000 - 81000 = 81000
if yu want to store 1 bucket more = 162000 + 81000 = 243000

commented

For all the years I've been playing modded this is the first time I've noticed fabric uses "su" to calculate water.
I'll have to move this to a feature request then. Thanks for teaching me something new :)