Treasure2!

Treasure2!

6M Downloads

[BUG] Occasionally chests are empty due to "tried to overfill..." error

Wabbit0101 opened this issue ยท 2 comments

commented

Loots like (ha!) when a dreaded "Tried to over-fill a container" error happens on LootTable.fillInventory the resulting chest is generated empty in the world. Which is a bummer for scarce and rarer chests (which have a lot of unstackables and does this noticeably when RNG generates lots of armor, weapons, and tools for the player).

commented

I haven't encountered this yet, but I will keep checking. The vanilla code doesn't indicate that an empty chest would be generated when the "over-fill" error happens, but rather, it just exists the method without any more attempts to add. At any rate, I changed the shuffleItems() method to simply shuffle the list and not split he item stacks. I didn't like the vanilla method doing that.

commented

I still haven't seen any evidence of this. closing.