Hello. As you can see here, I'm trying to free up the slot of a charmed item, and it lets me forge the ruby into the charmed adornment, but it doesn't free up the slot the empty charm has. Is this some sort of issue where it's not removing the charm? Also, the charm is from the Dwarven Talisman.

Could you show the tooltip of the original ring (input) in the anvil? From this pic, the result looks correct - 1 available slot, with a max of 2, and both are activated, so you could add another charm to this ring.
Maybe I'm not understanding what exactly you're asking?

What I was asking is why that when I put the ruby in, as per the documentation for removing charms from an adornment, it doesn't actually remove the charm, but still consumes the ruby?

Edit: I double checked what it said, and yes, it does say in the wiki part of this github that the slot becomes unavailable when you put a charm onto an adornment, and once that charm runs out, the slot remains unavailable, but you can free that slot back up by using a ruby, and neither the old charm is removed, nor does it show that all the slots are available again. What I was wanting to do is basically remove the empty charm from the adornment in order to load a full use version of the same charm onto the adornment so I don't have to get a new adornment whenever the old one runs out for the charm I'm using.

Ah, gotcha. I will have to look into why the empty charm isn't removed automatically upon depletion. Its been a while, I can't remember what my original thought was behind adornments and charms (if you needed a new adornment or not or if I was going to add something to recharge the charm).

Yeah, I'm not sure either, especially as I saw on the wiki that it said that the slot would still be unavailable, but I remember seeing somewhere where it said that recharging them would be added as a later feature. Maybe you could make a custom block that acts as a charm manager (maybe requiring a certain item that you can only find in treasure chests of a certain tier or higher) that has multiple functions: 1. It can take a charmed adornment and can remove a charm on it of your choice, maybe either have it be removed to a coin to preserve any remaining charges, be deleted if it's out of charges, or be put onto a book with that the charm cannot be used while it's attached to a book. 2. Recharge charmed adornments (not charmed coins or gems, only adornments) depending on what kind of item is used. This way for the higher tier charms, like the dwarven mining one, you have to either use lots of smaller recharging items, or work hard to make one big recharging item that fully brings it up to 75 from 0. 3. Attach charms to adornments, either from coins, or from the charmed books as mentioned before, with a material required to help transfer it (maybe like Lapis) depending on the tier of the charm. 4. If a charm has been removed from the adornment, its slot still needs to be opened up again, and so this would allow doing so by using a material that would be associated with the adornment, essentially like repairing the adornment in a way.

I was planning on totally re-vamping charms and adornments in the 1.16.5 port - having more structure to the charm levels and how adornments can be upgraded and fitted with charms. I'll take these ideas into consideration. I like the idea of having a Book that can contain a charm. When applied to an adornment it wouldn't cost a slot, making it a valuable (and rare) item. However i'm struggling with how to ensure items don't get OP or overloaded with charms and how to visually make this work that is intuitive.

Yeah, I can see that being an issue, although it would be cool to see this update to the charms in 1.12.2 as well. Also, speaking on that last point, you might also want to add a cap of how many instances of the same charm can stack with each other, as I was playing in a pack that I made just for myself, and I had the Dwarven Talisman in the FTB Quests shop, and I discovered in my survival world that multiple Dwarven Talisman charms stack, whether as a coin in a bag, or adornment in a bag, and I did some math, and having nine master bags of those charms, three being the coins themselves in a bag in your off hand, and the other eight bags being full on the first three slots with charmed adornments with that Dwarven Talisman charm, would result in one block becoming 7,450,580,596,923,828,125 blocks/items if the block broken normally dropped a single item (but can vary because of fortune for vanilla enchantments as well as Level up! Reloaded's ore doubling perk).

Yes, I tried implemented a limit in 1.12.2, but it was really only for adding charms to a single adornment, not having multiple charm-able items, like Dwarven Talisman. I think I have this fixed in the 1.16.5 version.

v2.0.0 implements multi-charms per adornment and ability to remove and charge them.