GAME VERSIONS:

Minecraft: 1.16.5
Forge: 36.2.19

MOD VERSIONS:

Treasure 2: f36.2.0-v1.7.2
Gottsch Core: f36.2.0-v1.5.0

DESCRIPTION:

Chests and Graves added by Treasure 2 do not generate and/or are replaced by a naturally generated block (such as stone, andesite, marble, etc.). The structures that contain them generate successfully, but as stated before the main features (Chests for loot, Graves as visual markers) fail to generate properly. The bug also seems to cause the pits/structures to generate a lot more frequently for some reason, until you do the temporary fix described later.

What happens: Bugged Generation
What's supposed to happen: Normal Generation

Steps to reproduce:

1.) Launch Minecraft
2.) Create (or join) a world. You should be able to see everything generating properly with spectator mode
3.) Leave the world and return to the main menu
4.) Create a new world (or join an existing world, even if it's the one you were just in. It doesn't matter, as long as new chunks are generated)
5.) If you joined an existing world, move away from where you were so that new chunks generate. If you created a new world, you can start looking for errors immediately
6.) You should be able to see that chests and graves are missing/replaced (as described above)

If you relaunch the game (close Minecraft, relaunch Minecraft, wait for it to load, join the same world/create a new world/join a different world), the generation of chests and graves will begin to work normally again. Repeating the above steps will produce the same bug described above, which can be temporarily fixed by following these steps.

Any chunks generated while the generation was broken on an existing world will stay broken (aka. doing the below fix will not cause existing chunks that failed to generate chests/graves to retroactively generate chests/graves).

Steps for temporary fix (as stated above):

1.) Leave the world you are in
2.) Close Minecraft
3.) Relaunch Minecraft
4.) Join the world that you were last in (the one where you noticed the buggy generation)
5.) If you joined an existing world, move away from where you were so that new chunks generate. If you created a new world, you can start looking to see if you temporarily fixed the bug immediately
6.) You should be able to see that chests and graves are generating properly again (until you break it by leaving that world and joining/creating another without relaunching Minecraft, as described above)

Thank you for the very thorough and detailed bug report. This sounds like the treasure loot table manager/registry is not initializing on entry/re-entry to a world. I will look into this... should be fairly easy to fix.

Fixed in v1.7.3