Hello! I found a sunken ship near my base with a Compressor Chest on it:

I couldn't find a way to open it by right-clicking, and I didn't see any locks on the side, so I decided to break it and take it with me to puzzle out later. It said it could be broken with an axe, so I tried to do just that, at which point the whole server crashed, disconnecting myself and my other player. When it restarted, the chest was still whole and everything seemed fine (so I'm just gonna leave it alone for now, lol).

Here's my diagnostic information and the crash log:

• Minecraft version: 1.12.2
• Forge version: forge-1.12.2-14.23.5.2846-universal
• Modpack version (links to current modlist): 1.7.1
• Mod versions: Treasure2 1.5.1, GottschCore 1.8.0

Link to crash log: https://pastebin.com/ECTe8BLQ

Thanks for your time, and for the great mod! Please let me know if there's any other information you need. :)

Tentatively, I blame lag for the locks failing to generate. We were struggling to maintain tps when a lot of the world was generating, so I'd guess it simply skipped the inventory/locks portion of the structure.

I think that's why I can't replicate now, as our tps issues are resolved. And in singleplayer, they never occurred.

If you do want to close the ticket for now, I can always reopen it if I find evidence that suggests my hypothesis is incorrect. Whichever you prefer!

And don't worry about it. <3 My players and I are certainly excited for the update, but we don't mind waiting. Your life should come first!

Thanks again for all your debugging info. Unfortunately I haven't been able to find anything in the code that would lead to the is problem yet. I might leave this ticket open after v1.6.0 comes out and hopefully it is fixed (i've changed a lot of the code related to generation). And for anyone who is waiting, sorry that 1.6.0 is taking so long.

I've found some new information that might be relevant. It seems that Roots is having issues with world gen when players use ChunkPregenerator, that leaves Structure Blocks visible in the world. It sounds a lot like this issue: #84

And I suspect this may be related as well. To my knowledge, all of the incorrectly generated treasure chests were within the pregenerated chunks. Which would explain both why it's only happened a couple of times on the server, and also why I couldn't replicate it in singleplayer!

For now I'm gonna consider this solved, so I'm going to close the issue.

1. So no locks at all? - they can be on all four sides with a compressor chest.
2. has this happened to you with any other chest?
3. Also, is this an old world, ie. created with a previous version of Treasure?

Nope, no locks. I checked all four sides.

To my knowledge, this is the only time this has happened with any chest.

We only just added Treasure 2 to the modlist, so it's always been version 1.5.1.

I can clip the region file for you if you want, just let me know.

Got a second crash, this time a Dread Pirate Chest. Again, no locks. Wouldn't open when right-clicked. A player tried to break it, and the server died.

https://pastebin.com/p6Sz2Ccd

Edit: I also have an excerpt from the latest.log: https://pastebin.com/dFi48h2t

So was this one underwater as well?

(btw, i think both chests are throwaway...or rather you could place them again, but they will not have any loot).

Just checked, yes this one was underwater also.

I am not sure if it was the same type of structure. Once I get to my computer, I'll get the coordinates from the crash report and go look.

And yes, I can enable debugging. Does that need to be both client and server?

Is this still happening? Was it the same ship/structure? If you are still using the mod, could you turn logging on (in config, set loggerLevel=debug). The chests are working fine on their own, but something about the underwater generation is causing issues.

I would enable it it on the server. Thanks for looking into this.

Okay, so I've enabled the debug logger on my server, it'll go live at 4pm. I also decided to see if I could replicate it in singleplayer. I turned spawning of structures up as high as it would go (admittedly, I didn't notice a significant difference in spawn frequency) and flew around an "Archipelago" BoP world type for about an hour. Only spied about 5-6 total structures, and only 4 were underwater. All of them seemed to correctly generate locks, however.

Here's the log, just for funsies: https://paste.ee/p/l6x9W

There did appear to be a few errors in there so perhaps they'll help somehow.

Just got to check the structure, it is not the same one. Unfortunately, the chest was broken when I got here - presumably my moderator smashed it in creative so no one could crash the server again. Here is the more recent of the two:

The previous structure was a significantly smaller boat:

Also perhaps of note, in the larger boat there was a pig spawner for some reason, lol.