Trickster

Trickster

1.4k Downloads

Game crashes when casting not on mirror

Ch1216 opened this issue ยท 14 comments

commented

I was on a minecraft world opened to LAN, I used morph on another player, and the game crashed
The mods on both clients were trickster + required dependencies listed on modrinth + pehkui

crash-2024-07-30_18.33.41-server.txt
latest.log

commented

That is helpful information, as I cannot currently test Polymorph Ploy but I can certainly test Ploy of Destruction.

commented

I also wanted to mention that this might be more grand than just polymorph, I tried to do Reflection Delusion to Archer's Distortion to Ploy of Destruction, and my game crashed

latest.log
crash-2024-07-30_19.36.02-server.txt

commented

Is this the spell you used? It works fine in singleplayer in my development environment. The last log you sent me was also in singleplayer, correct?
image

Was your instance originally on a previous version of Trickster, and was updated to 2.0.0-alpha.3? Or is this a new instance?

commented

Yes its that spell, Yes it crashed on single player, my instance was always on 2.0.0-alpha.3
Also just found out Resonance Ploy is also crashing the game, so far only Ploy of Occupation is the only ploy that does not crash me

commented

This is rather concerning. I'll keep poking about. Let us know if there are any changes to the situation.

commented

ok, so I think the problems is not any specific spell, but rather using a wand to cast anything, as casting change scale with wand and top hat+scroll the game crashes, but casting destroy block or resonance signal change with the mirror does not crash it

commented

[...] Reading the stack trace, this appears to be an issue with the new execution engine. [...]

Seems like it.

commented

I've pulled master and will be testing to see if it is possibly fixed by #23.

commented

I can confirm the issue on master, and so this is likely fixed by #23, where I tested it first. As the issue is with the new queued execution engine, the mirror is unaffected. There is a tweak made in #23 that modifies this portion of the engine, unintentionally fixing it.

Thank you for opening an issue. The fix should be there next release.

commented

Hello. Reading the stack trace, this appears to be an issue with the new execution engine. Could you provide further details?

My questions are:

  1. Which item did you use to cast the spell?
  2. Is the server running in offline mode?
  3. Is this issue reproducible with a minimum spell consisting only of a raycast and polymorph?
commented
  1. I used a scroll in a top hat with a wand
  2. I assume not since the accounts had their skins, which would not happen if it was offline, I think
  3. I tested it using only Reflection Delusion, Scout's Distortion to Polymorph Ploy in a wand, and it still crashed the game, I dont know how only using a raycast and polymorph would work isince Polymorph needs 2 entity iotas

Also, additionally, the trick does work, when i opened back the world I looked like the other account, and had their name tag, it actually confused me since I thought modrinth launcher bugged out due to having 2 instanced opened under different accounts, but I realized that it was just the trick when iItyped in chat or looked at the tab list.

commented

LAN servers are typically in online mode, I was asking as polymorph is unsupported in offline mode, and wanted to be certain it wasn't that.

Regarding "only using a raycast and polymorph", I apologize for my lack of clarity. I meant what you say you tested it with.

If the trick worked, then I assume the spell progress was saved. Could you provide the output of running Showcase Stratagem on the wand's inscribed spell? (Or just type it up, if it's not too long... I assume it's a standard read-and-cast?)

commented

ihadtosearchthegithubtofindwhereshowcasestratagemwas
I assume this is what you wanted?

commented

Oh when you tested it you put it directly on the wand. Hm. Alright.
Thanks for the info. We'll look into this when we can.