Trinkets and Baubles

Trinkets and Baubles

13M Downloads

[1.12.2] Using any of the resize rings while morphed into something else other than the player causes an 'auto-walk' of some sorts. The model also doesn't resize.

SonicX8000 opened this issue ยท 5 comments

commented

Minecraft: 1.12.2
Forge: 14.23.5.2772

Mods: 3
Baubles-1.12-1.5.2
Trinkets+and+Baubles-1.12.2-0.19
metamorph-1.1.6-1.12.2


I equipped the Ring of Fairies while being morphed as a Parrot via Metamorph, and I noticed that the model doesn't resize. It also does this weird auto-walk in one direction which stops when you unequip the ring. If you don't... you may get pushed into the wall rapidly and take suffocation damage.

I am going guess that since Metamorph does a model/hitbox resize depending on the mob you are morphed into. The ring is trying to resize you which perhaps isn't playing along nicely.

This may also conflict with another mod called Morph. Maybe one shouldn't use both the morph & resize rings at the same time perhaps?

commented

sliding issue fixed, the Rendering thing would require making metamorph a dependency or some really advanced level java, and I just haven't learned Enough to do that yet, so for now, Marking this as closed

commented

Hmm, Thanks for letting me know, I'll have to look into it, I Actually did some testing with Ichun's Morph mod in my Dev environment because of previously mentioned issues and had no problems, so sounds like Metamorph is doing their size adjustments a different way, Yeah

Unfortunately I wont be able to work on it today Nov 13th because I'm going to a Funeral for a family member, I'll try and look into it sometime tonight after getting home, or tomorrow

commented

I Think I Managed to fix the "Auto-Walk" issue, or at least in my Dev Environment it seems to be fine, The Resize Rings kind of worked with IChun's morph mod, but because of some code conflicts that I couldn't safely account for, I was forced to just not allow the player to transform while morphed, I'm still looking into it though and I'll see if I Can find another method and maybe allow for it, but if i push out a hotfix anytime soon, it'll probably just prevent the player to morph using metamorph when using the rings

commented

It's perhaps easier to disallow the resize rings from being used if morphed into anything other than the player, as Morph changes the model & hitbox depending on the mob. I wouldn't know what it would do if you... say, morphed into one of those Dragon from Ice & Fire while wearing the Ring of Fairies and those models tend to be... big.

commented

Metamorph uses it's own Rendering System when the player is Morphed, IChun's Morph Mod Basically Spawns a Dummy Mob at the player in which you control.

It would take a lot of work to get the Shrinking effect to work with Metamorph and I Just can't invest the time into doing that right now, I did get the Auto-walk issue fixed though, so for now I'm going to put this on my todo list for a future update.

I Might get an Minor update out in a few days maybe with some code cleanup and other stuff, it'll have the Auto-walk fix in it as well but not much else for now.