Trinkets and Baubles

Trinkets and Baubles

15M Downloads

[1.12.2] Ring of Fairies/Dwarfs doesn't work in the bottom Baubles Ring Slot.

SonicX8000 opened this issue ยท 5 comments

commented

Minecraft: 1.12.2
Forge: 14.23.5.2778

Mods: 2
Baubles-1.12-1.5.2
Trinkets+and+Baubles-1.12.2-0.19


If these rings are in the top slot... they work, but if in the bottom slot... nothing happens. Unless... this is intended so the player can't stack the effects? The other rings seem to work fine in the bottom slot like the Wither Ring.

P.S.
If you swap out a resize ring with another ring in the same slot, your model won't resize but your hitbox will act as normal, if you unequip the ring so the slot is empty... your model will resize back to normal.

commented

If you've only got baubles and my mod installed only, then this is most likely an unintended issue with how I was checking if the player had the bauble equipped, however, I actually recently found that if you have projectE installed, and I have no idea why, but they wont work for the bottom ring slot as you've described and are showing, this has made me rework how I do the check, I'll try and get an update out sometime tonight or tomorrow that will have the fix, I just need to remove some useless code I had and do another round of testing and I can push a 0.20 version

commented

Also, Sorry it took so long in replying, I've been busy helping another modder out with one of their projects and hadn't had the chance to check everything

commented

It's alright, no rush.

commented

Ok, update pushed, I think it was fixed, If still have issues, let me know

commented

Appears to work fine now, also fixed the bug where if you switch the resizing ring out with a different ring, the model wouldn't re-scale unless the slot was empty. All good.