Trinkets (Fabric)

Trinkets (Fabric)

22M Downloads

3.3.0's Maven POM declares dependency on Mod Menu

quat1024 opened this issue ยท 1 comments

commented

It appears that the first 1.18.2 commit 90e9a1d added a modImplementation dependency on Mod Menu, instead of something like modLocalRuntime. This dependency is getting pushed through the Maven POM and so downstream consumers of Trinkets end up requiring it as well.

I suspect that this went unnoticed because ModMenu and Trinkets both come from TerraformersMC's maven, so in most projects there are no issues resolving the depedency. However, in Gradle it's possible to filter which artifacts can come from which maven servers, and the extra dependency will surprise anyone who does this (like my project lol)

Not a super critical thing that needs to be fixed, affected consumers can simply add includeGroup("com.terraformersmc") to terraformersmc's maven filter. Just something I think you should be aware of.

commented

Well on the bright side, this called attention to me forgetting to add an icon to the mod