Trinket data not loading or syncing or *something*
LemmaEOF opened this issue ยท 14 comments
We're running into an issue on the BlanketCon server where no player has any trinket slots. At all. There are no logs indicating why this might be happening, whether it's an issue with loading data or sending it to clients, or anything else. We're on Trinkets 3.3.0 with multiple Trinket adding mods in the pack (primarily Botania). Pack and server are available in the BlanketCon organization discords.
It's caused by the Server Translations API.
It causes the slot loaders in Trinkets to simply not be called; nothing to do with packets, the data just is never loaded.
Specifically, this beautiful mixin, containing an unconditional cancel: https://github.com/arthurbambou/Server-Translations/blob/1.18.2/api/src/main/java/fr/catcore/server/translations/api/mixin/DataPackContentsMixin.java
The mixin is new in the 1.18.2 port.
also doesn't fabric literally have a hook for this so they don't need to break everyone else's RRLs
The list returned in that method is constructed via List.of, so it's immutable. A copy is actually necessary.
Fabric does have a hook here, but it works differently. I'm not sure where it injects, and that's not really my concern at the moment. Trinkets works in the BlanketCon pack with a simple patch.
Oh it actually looks like Fabric uses a transitive access widener now - I've filed an issue on their repo
It's also happening in singleplayer.
Earlier versions of the pack didn't have this issue; I'm trying to isolate a culprit.
Weird mod combos have caused trinkets to not function in the past. Stuff that doesn't even touch trinkets. I assume it has something to do with data loading or packets, but I haven't had the time to look into it.
Wait what broken mod was it? I'm wondering cause I'm suffering the exact same issue
Oh, we did in this case, it had to do with an broken mod that we fixed, this can be closed