Trinkets (Fabric)

Trinkets (Fabric)

22M Downloads

Add Support for Entity Model Features: Player Animations

HB-Stratos opened this issue ยท 1 comments

commented

Entity Model Features adds compatibility for Optifine's Custom Entity Models, and extends the system so resource packs can animate the player too. This requires a custom renderer for the player model, which currently doesn't work with the TrinketRenderer.translateTo... functions. The result is that cosmetics rendered by custom renderers, like the create mod goggles (renderer code here), do not move correctly with the player as they assume vanilla player model movement.

Jdk-17.0.8.101-hotspot.2024.05.17.-.09.40.49.03.mp4

Having searched around a bit I believe the best way to fix this may be to extend the TrinketRenderer.translateTo... functions to detect whether EMF is currently present and the custom player model feature is in use, and if so, it should provide rotation matrices that follow the player model rendered by EMF.

commented

Same problem. I think all mods that make the player have extra animations cause this issue, because it happened with Immersive Melodies and Better Combat

Unless those two use EMF too?