Tropicraft

Tropicraft

Mods
9M Downloads

ERROR

Mgazul opened this issue ยท 8 comments

commented

Issue Description

ERROR

Steps to Reproduce

Tropicraft Version: tropicraft-MC1.12.2-7.1.5.85
Forge Version: 14.23.5.2772

Crash log

Gist

commented

Do you have the latest.log for this crash?

commented

No crash. This error occurs when the server is first started or after the player enters the server.

commented

Ignore that, that commit won't fix this.

commented

Anyways, this does not seem related to Tropicraft. It helped me find an unrelated bug, but we do not control when netty's ByteBufs are released. This sounds like a forge or even netty bug, way beyond what we control. It's probably safe to ignore.

commented

thank! I will check my own problems!

commented

You're leaking the buffer here:

Tropicraft/src/main/java/net/tropicraft/core/common/network/MessagePlayerSwimData.java

Line 30 in 93f3044

UUID uuid = UUID.fromString(new String(buf.readBytes(len).toString(Charset.defaultCharset())));

buf.readBytes(len) creates a new buffer, see the Javadoc.

commented

Thanks, this should be actually resolved now.

commented

Yes, the problem has been solved