DisableBlockBreakingParticles has no effect
MeeniMc opened this issue · 6 comments
The problem
Option DisableBlockBreakingParticles has no effect. When setting it to enabled, block breaking still produces particles.
Amusingly, option DisableParticles works and do disable block breaking particles (as well as other particles).
Setup
[email protected]
[email protected]
[email protected]+build.414-1.16, [email protected]+fb0d9b0e95, [email protected]+a4467d2a95, [email protected]+build.1
[email protected]+build.213,
[email protected]+build.31
This has been the case in prior versions as well (at least since September).
You must have other mods that interfere with it then. I haven't touched that code in a long time, and I know for sure it works on its own. I guess I need to test it with the latest Fabric API, if it has a particles module, I don't know what it does/touches...
I also suspected fool play from bad interaction with something else, hence the mods listed above are everything that's loaded for that test (there are mode sub-parts of fabric-api that I didn't list because they didn't look like relevant).
I can't reproduce this with just Fabric API 0.25.4 and Tweakeroo (and my other client mods and Mod Menu). I also tested with OpiFabric + Optifine and that also works. So I'd suggest you to try to narrow down the conflicting mod on your side, by removing whatever other mods you have than these. Start with anything that might touch or modify rendering things.
I just restarted from a fresh instance, erased config/ mods/ folders, downloaded 1.16.4, installed fabric, fabric-api, malilib, tweakeroo, all fresh downloads from curse. I also reset java to OpenJDK 1.8 and launch options to default.
Same behavior.
Full log.
MultiMC version: 0.6.11-1430
Minecraft folder is:
D:/Minecraft/MultiMC/instances/1.16.4 naked/.minecraft
Java path is:
C:/Program Files/AdoptOpenJDK/jdk-8.0.265.01-hotspot/bin/javaw.exe
Java is version 1.8.0_265, using 64-bit architecture.
Main Class:
net.fabricmc.loader.launch.knot.KnotClient
Native path:
D:/Minecraft/MultiMC/instances/1.16.4 naked/natives
Traits:
traits FirstThreadOnMacOS
traits XR:Initial
Libraries:
D:/Minecraft/MultiMC/libraries/org/lwjgl/lwjgl-glfw/3.2.2/lwjgl-glfw-3.2.2.jar
D:/Minecraft/MultiMC/libraries/org/lwjgl/lwjgl-jemalloc/3.2.2/lwjgl-jemalloc-3.2.2.jar
D:/Minecraft/MultiMC/libraries/org/lwjgl/lwjgl-openal/3.2.2/lwjgl-openal-3.2.2.jar
D:/Minecraft/MultiMC/libraries/org/lwjgl/lwjgl-opengl/3.2.2/lwjgl-opengl-3.2.2.jar
D:/Minecraft/MultiMC/libraries/org/lwjgl/lwjgl-stb/3.2.2/lwjgl-stb-3.2.2.jar
D:/Minecraft/MultiMC/libraries/org/lwjgl/lwjgl-tinyfd/3.2.2/lwjgl-tinyfd-3.2.2.jar
D:/Minecraft/MultiMC/libraries/org/lwjgl/lwjgl/3.2.2/lwjgl-3.2.2.jar
D:/Minecraft/MultiMC/libraries/com/mojang/patchy/1.1/patchy-1.1.jar
D:/Minecraft/MultiMC/libraries/oshi-project/oshi-core/1.1/oshi-core-1.1.jar
D:/Minecraft/MultiMC/libraries/net/java/dev/jna/jna/4.4.0/jna-4.4.0.jar
D:/Minecraft/MultiMC/libraries/net/java/dev/jna/platform/3.4.0/platform-3.4.0.jar
D:/Minecraft/MultiMC/libraries/com/ibm/icu/icu4j/66.1/icu4j-66.1.jar
D:/Minecraft/MultiMC/libraries/com/mojang/javabridge/1.0.22/javabridge-1.0.22.jar
D:/Minecraft/MultiMC/libraries/net/sf/jopt-simple/jopt-simple/5.0.3/jopt-simple-5.0.3.jar
D:/Minecraft/MultiMC/libraries/io/netty/netty-all/4.1.25.Final/netty-all-4.1.25.Final.jar
D:/Minecraft/MultiMC/libraries/com/google/guava/guava/21.0/guava-21.0.jar
D:/Minecraft/MultiMC/libraries/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar
D:/Minecraft/MultiMC/libraries/commons-io/commons-io/2.5/commons-io-2.5.jar
D:/Minecraft/MultiMC/libraries/commons-codec/commons-codec/1.10/commons-codec-1.10.jar
D:/Minecraft/MultiMC/libraries/com/mojang/brigadier/1.0.17/brigadier-1.0.17.jar
D:/Minecraft/MultiMC/libraries/com/mojang/datafixerupper/4.0.26/datafixerupper-4.0.26.jar
D:/Minecraft/MultiMC/libraries/com/google/code/gson/gson/2.8.0/gson-2.8.0.jar
D:/Minecraft/MultiMC/libraries/com/mojang/authlib/2.0.27/authlib-2.0.27.jar
D:/Minecraft/MultiMC/libraries/org/apache/commons/commons-compress/1.8.1/commons-compress-1.8.1.jar
D:/Minecraft/MultiMC/libraries/org/apache/httpcomponents/httpclient/4.3.3/httpclient-4.3.3.jar
D:/Minecraft/MultiMC/libraries/commons-logging/commons-logging/1.1.3/commons-logging-1.1.3.jar
D:/Minecraft/MultiMC/libraries/org/apache/httpcomponents/httpcore/4.3.2/httpcore-4.3.2.jar
D:/Minecraft/MultiMC/libraries/it/unimi/dsi/fastutil/8.2.1/fastutil-8.2.1.jar
D:/Minecraft/MultiMC/libraries/org/apache/logging/log4j/log4j-api/2.8.1/log4j-api-2.8.1.jar
D:/Minecraft/MultiMC/libraries/org/apache/logging/log4j/log4j-core/2.8.1/log4j-core-2.8.1.jar
D:/Minecraft/MultiMC/libraries/com/mojang/text2speech/1.11.3/text2speech-1.11.3.jar
D:/Minecraft/MultiMC/libraries/net/fabricmc/intermediary/1.16.4/intermediary-1.16.4.jar
D:/Minecraft/MultiMC/libraries/net/fabricmc/tiny-mappings-parser/0.2.2.14/tiny-mappings-parser-0.2.2.14.jar
D:/Minecraft/MultiMC/libraries/net/fabricmc/sponge-mixin/0.8.2+build.24/sponge-mixin-0.8.2+build.24.jar
D:/Minecraft/MultiMC/libraries/net/fabricmc/tiny-remapper/0.3.0.70/tiny-remapper-0.3.0.70.jar
D:/Minecraft/MultiMC/libraries/net/fabricmc/access-widener/1.0.0/access-widener-1.0.0.jar
D:/Minecraft/MultiMC/libraries/net/fabricmc/fabric-loader-sat4j/2.3.5.4/fabric-loader-sat4j-2.3.5.4.jar
D:/Minecraft/MultiMC/libraries/com/google/jimfs/jimfs/1.2-fabric/jimfs-1.2-fabric.jar
D:/Minecraft/MultiMC/libraries/org/ow2/asm/asm/9.0/asm-9.0.jar
D:/Minecraft/MultiMC/libraries/org/ow2/asm/asm-analysis/9.0/asm-analysis-9.0.jar
D:/Minecraft/MultiMC/libraries/org/ow2/asm/asm-commons/9.0/asm-commons-9.0.jar
D:/Minecraft/MultiMC/libraries/org/ow2/asm/asm-tree/9.0/asm-tree-9.0.jar
D:/Minecraft/MultiMC/libraries/org/ow2/asm/asm-util/9.0/asm-util-9.0.jar
D:/Minecraft/MultiMC/libraries/net/fabricmc/fabric-loader/0.10.6+build.214/fabric-loader-0.10.6+build.214.jar
D:/Minecraft/MultiMC/libraries/com/mojang/minecraft/1.16.4/minecraft-1.16.4-client.jar
Native libraries:
D:/Minecraft/MultiMC/libraries/org/lwjgl/lwjgl-glfw/3.2.2/lwjgl-glfw-3.2.2-natives-windows.jar
D:/Minecraft/MultiMC/libraries/org/lwjgl/lwjgl-jemalloc/3.2.2/lwjgl-jemalloc-3.2.2-natives-windows.jar
D:/Minecraft/MultiMC/libraries/org/lwjgl/lwjgl-openal/3.2.2/lwjgl-openal-3.2.2-natives-windows.jar
D:/Minecraft/MultiMC/libraries/org/lwjgl/lwjgl-opengl/3.2.2/lwjgl-opengl-3.2.2-natives-windows.jar
D:/Minecraft/MultiMC/libraries/org/lwjgl/lwjgl-stb/3.2.2/lwjgl-stb-3.2.2-natives-windows.jar
D:/Minecraft/MultiMC/libraries/org/lwjgl/lwjgl-tinyfd/3.2.2/lwjgl-tinyfd-3.2.2-natives-windows.jar
D:/Minecraft/MultiMC/libraries/org/lwjgl/lwjgl/3.2.2/lwjgl-3.2.2-natives-windows.jar
D:/Minecraft/MultiMC/libraries/com/mojang/text2speech/1.11.3/text2speech-1.11.3-natives-windows.jar
Mods:
[✔️] fabric-api-0.25.4+1.16
[✔️] malilib-fabric-1.16.4-0.10.0-dev.21+arne.1
[✔️] tweakeroo-fabric-1.16.4-0.10.0-dev.20201110.132827
Params:
--username --version MultiMC5 --gameDir D:/Minecraft/MultiMC/instances/1.16.4 naked/.minecraft --assetsDir D:/Minecraft/MultiMC/assets --assetIndex 1.16 --uuid --accessToken --userType --versionType release
Window size: max (if available)
Java Arguments:
[-XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump, -Xms8192m, -Xmx8192m, -Duser.language=en]
Minecraft process ID: 13284
Using onesix launcher.
[16:29:53] [main/INFO]: Loading for game Minecraft 1.16.4
[16:29:53] [main/INFO]: [FabricLoader] Loading 43 mods: [email protected]+a4467d2a3a, [email protected]+872498413a, [email protected], [email protected]+b50ffc7b3a, [email protected]+3fa9f7c53a, [email protected]+a4467d2a3a, [email protected]+build.214, [email protected]+c93221003a, [email protected]+f8ac1db23a, [email protected]+a4467d2a3a, [email protected]+045df74f3a, [email protected]+a89534ab3a, [email protected]+f8ac1db23a, [email protected]+b7f9825d3a, [email protected]+f8ac1db23a, [email protected]+a4467d2a3a, [email protected]+9f0fb4b83a, [email protected]+f8ac1db23a, [email protected]+f8ac1db23a, [email protected]+730711c63a, [email protected]+f8ac1db23a, [email protected]+facf3bbf3a, [email protected], [email protected]+arne.1, [email protected]+a4467d2a3a, [email protected]+059ea8663a, [email protected]+ac8e8c593a, [email protected]+8367596d3a, [email protected]+f8ac1db23a, [email protected]+a4467d2a3a, [email protected]+52d308363a, [email protected]+c6a8ea893a, [email protected]+74cc3b203a, [email protected]+b764ce993a, [email protected]+f8ac1db23a, [email protected]+432ea1883a, [email protected]+16acbe5b3a, [email protected]+1.16, [email protected]+f8ac1db23a, [email protected]+fb0d9b0e3a, [email protected]+a4467d2a3a, [email protected]+e00ecb5f3a, [email protected]+a4467d2a3a
[16:29:53] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8.2 Source=file:/D:/Minecraft/MultiMC/libraries/net/fabricmc/sponge-mixin/0.8.2+build.24/sponge-mixin-0.8.2+build.24.jar Service=Knot/Fabric Env=CLIENT
[16:29:56] [main/INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD'
[16:29:56] [main/INFO]: [Indigo] Registering Indigo renderer!
[16:29:56] [main/INFO]: Backend library: LWJGL version 3.2.2 build 10
[16:29:58] [main/INFO]: Narrator library for x64 successfully loaded
[16:29:58] [main/INFO]: Reloading ResourceManager: Default, Fabric API, Fabric API Base, Fabric Biome API (v1), Fabric BlockRenderLayer Registration (v1), Fabric Containers (v0), Fabric Content Registries (v0), Fabric Crash Report Info (v1), Fabric Events Interaction (v0), Fabric Events Lifecycle (v0), Fabric Game Rule API (v1), Fabric Item API (v1), Fabric Item Groups (v0), Fabric Key Binding API (v1), Fabric Key Bindings (v0), Fabric Lifecycle Events (v1), Fabric Loot Tables (v1), Fabric Mining Levels (v0), Fabric Models (v0), Fabric Networking Block Entity (v0), Fabric Networking (v0), Fabric Object Builder API (v1), Fabric Object Builders (v0), Fabric Registry Sync (v0), Fabric Renderer API (v1), Fabric Renderer - Indigo, Fabric Renderer Registries (v1), Fabric Rendering Data Attachment (v1), Fabric Rendering Fluids (v1), Fabric Rendering (v0), Fabric Rendering (v1), Fabric Resource Loader (v0), Fabric Screen Handler API (v1), Fabric Tag Extensions (v0), Fabric Textures (v0), Fabric Tool Attribute API (v1), Fabric Loader, MaLiLib, Tweakeroo, Fabric Command API (v1)
[16:30:01] [main/INFO]: OpenAL initialized.
[16:30:01] [main/INFO]: Sound engine started
[16:30:01] [main/INFO]: Created: 1024x1024x4 minecraft:textures/atlas/blocks.png-atlas
[16:30:01] [main/INFO]: Created: 256x128x4 minecraft:textures/atlas/signs.png-atlas
[16:30:01] [main/INFO]: Created: 1024x512x4 minecraft:textures/atlas/banner_patterns.png-atlas
[16:30:01] [main/INFO]: Created: 1024x512x4 minecraft:textures/atlas/shield_patterns.png-atlas
[16:30:01] [main/INFO]: Created: 256x256x4 minecraft:textures/atlas/chest.png-atlas
[16:30:01] [main/INFO]: Created: 512x256x4 minecraft:textures/atlas/beds.png-atlas
[16:30:01] [main/INFO]: Created: 512x256x4 minecraft:textures/atlas/shulker_boxes.png-atlas
[16:30:01] [main/INFO]: Created: 256x256x0 minecraft:textures/atlas/particles.png-atlas
[16:30:01] [main/INFO]: Created: 256x256x0 minecraft:textures/atlas/paintings.png-atlas
[16:30:01] [main/INFO]: Created: 256x128x0 minecraft:textures/atlas/mob_effects.png-atlas
[16:30:32] [main/WARN]: Ambiguity between arguments [teleport, destination] and [teleport, targets] with inputs: [Player, 0123, @e, dd12be42-52a9-4a91-a8a1-11c01849e498]
[16:30:32] [main/WARN]: Ambiguity between arguments [teleport, location] and [teleport, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[16:30:32] [main/WARN]: Ambiguity between arguments [teleport, location] and [teleport, targets] with inputs: [0.1 -0.5 .9, 0 0 0]
[16:30:32] [main/WARN]: Ambiguity between arguments [teleport, targets] and [teleport, destination] with inputs: [Player, 0123, dd12be42-52a9-4a91-a8a1-11c01849e498]
[16:30:32] [main/WARN]: Ambiguity between arguments [teleport, targets, location] and [teleport, targets, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[16:30:32] [main/INFO]: Reloading ResourceManager: Default, Fabric Tool Attribute API (v1)
[16:30:32] [main/INFO]: Loaded 7 recipes
[16:30:32] [main/INFO]: Loaded 927 advancements
[16:30:32] [main/INFO]: Applied 0 biome modifications to 0 of 79 new biomes in 938.9 ?s
[16:30:33] [main/INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD'
[16:30:33] [Server thread/INFO]: Starting integrated minecraft server version 1.16.4
[16:30:33] [Server thread/INFO]: Generating keypair
[16:30:33] [Server thread/INFO]: Preparing start region for dimension minecraft:overworld
[16:30:33] [main/INFO]: Preparing spawn area: 0%
[16:30:33] [main/INFO]: Preparing spawn area: 0%
[16:30:33] [main/INFO]: Time elapsed: 661 ms
[16:30:34] [Server thread/INFO]: Changing view distance to 23, from 10
[16:30:34] [Server thread/INFO]: Saving and pausing game...
[16:30:34] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:overworld
[16:30:34] [main/INFO]: Loaded 7 advancements
[16:30:35] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_nether
[16:30:35] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_end
[16:30:41] [Server thread/INFO]: Saving and pausing game...
[16:30:41] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:overworld
[16:30:42] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_nether
[16:30:42] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_end
[16:31:03] [main/WARN]: Unable to play empty soundEvent: minecraft:entity.salmon.ambient
[16:31:09] [main/INFO]: [CHAT] Unknown or incomplete command, see below for error
[16:31:09] [main/INFO]: [CHAT] /data s+@s<--[HERE]
[16:31:30] [Server thread/INFO]: Saving and pausing game...
[16:31:30] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:overworld
[16:31:30] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_nether
[16:31:30] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_end
[16:31:30] [Server thread/INFO]: Stopping singleplayer server as player logged out
[16:31:30] [Server thread/INFO]: Stopping server
[16:31:30] [Server thread/INFO]: Saving players
[16:31:30] [Server thread/INFO]: Saving worlds
[16:31:30] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:overworld
[16:31:32] [Server thread/INFO]: ThreadedAnvilChunkStorage (New World): All chunks are saved
[16:31:32] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_nether
[16:31:32] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM-1): All chunks are saved
[16:31:32] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_end
[16:31:32] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM1): All chunks are saved
[16:31:32] [Server thread/INFO]: ThreadedAnvilChunkStorage (New World): All chunks are saved
[16:31:32] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM-1): All chunks are saved
[16:31:32] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM1): All chunks are saved
[16:31:33] [main/INFO]: Stopping!
Process exited with code 0.
I don't understand how that would be possible. It works for me so the mod can't be simply broken entirely in that regard... And I haven't heard anyone else have issues with it.
How are you testing this?
There are two similarly named methods for block break(ing) particles. I'm only canceling one of them. Looks like the other one might be used for some smaller hit particles.