Typographical Error In Tooltip
WolfPack30156 opened this issue · 6 comments
Issue description
In the configuration menu the tooltip message / on-hover message for tweakLavaVisibility has a typo in the displayed text.
Steps to reproduce the issue
- Load into a SMP world
- Press X+C to open config
- Click into Tweak Toggles
- Scroll until tweakLavaVisibility is visible
- Hover over tweakLavaVisibility
What's the expected result?
- Display a tooltip with the following text 'If enabled and the player has a Respiration helmet and/or Water Breathing active, the lava fog is greatly reduced.'
What's the actual result?
- Displays a tooltip with the following text ''If enabled and the player has a Respiration helmet and/or Wahter Breathing active, the lava fog is greatly reduced.'
Additional details / screenshot
I think in general for trivial stuff like typo fixes, especially if the user discovering it is already on any of the Discord servers I'm on, I would prefer a ping on Discord to let me know about it. Pull Requests and merges just create a lot more noise in the commit history for very minor changes. But anyway, thanks for letting me know about this... :D
Apologies for that, I am not in your discord.
Thank you for your time and response!
…On Sat, Aug 17, 2019, 10:03 Matti Ruohonen ***@***.***> wrote:
I think in general for trivial stuff like typo fixes, especially if the
user discovering it is already on any of the Discord servers I'm on, I
would prefer a ping on Discord to let me know about it. Pull Requests and
merges just create a lot more noise in the commit history for very minor
changes. But anyway, thanks for letting me know about this... :D
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14?email_source=notifications&email_token=AMACO3HF7VV4XQP7SJQCSJDQFAAMLA5CNFSM4IMOSF52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4QMA2A#issuecomment-522240104>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMACO3FDDCFX2PQQVKTVHPTQFAAMLANCNFSM4IMOSF5Q>
.
haha
btw What should one do when he finds a problem like this. What is better a Pull request or a issue?
Over all to change one line, I know how to do an issue, still learning
GitHub on pr.
…On Sat, Aug 17, 2019, 06:21 Anunay Jain ***@***.***> wrote:
haha
btw What should one do when he finds a problem like this. What is better a
Pull request or a issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14?email_source=notifications&email_token=AMACO3FUBCJT3BHPYVF6WKTQE7GMHA5CNFSM4IMOSF52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4QILWA#issuecomment-522225112>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMACO3CTDW56OGP35FKSWATQE7GMHANCNFSM4IMOSF5Q>
.
I opened a pull request for this: #15 , if that is what one should do.