Universal Graves

Universal Graves

3M Downloads

Graves drop Backslot items outside if Charm is present

SplendidAlakey opened this issue ยท 4 comments

commented

MC 1.17.1
Fabric loader 0.12.5; API 0.42.1
Charm 3.3.3
UniversalGraves 1.1.4
Backslot 1.2.2

When all 3 mods are installed and any items are present in the back slots, it will get dropped outside of a grave upon dying.

To reproduce:

  1. Install all 3 mods and its dependencies; launch the game to generate configs
  2. Set "TotemOfPreserving Enabled" = false in charm.toml, otherwise it overrides any grave mod
  3. Get into a world, take 2 swords, place them in the back slots and die
  4. Get back to the grave to discover that the swords are outside of a grave (if there were no other items in the inventory, the grave will also not be created as if you were carrying no items)

Without Charm installed, items kept in back slots are put in the grave as intended. No other items are affected, you can carry anything else in your inventory and it will get saved in your grave upon death. The bug happens even if everything in charm.toml is set to false.

Logs: https://gist.github.com/Footage2-Amply-Pounce/aba191bbe03003be816913a265240598

commented

Well, since there is no updates, I will take that as resolved

commented

Thats interesting. However that should be caused by some outside factor, not Universal Graves. I would say you should report that on BackSlots repo too, as it seems like something that shouldn't be caused by my mod.

commented

Thanks for the reply. I reported it to Backslot and I actually should've taken a look at their repo first. I suspect the bug is caused by Backslot because they had a bug where items outright disappeared when used together with Charm's totem of preserving, and they fixed it with this PR. Maybe they could implement a similar check for UniversalGraves.

You can close this issue since it's not caused by your mod, otherwise I will keep it open until it's fixed just in case someone else comes across this bug.

commented

I will also keep it open to avoid duplicates