Universal Graves

Universal Graves

3M Downloads

percentage xp drop incompatible with mods that increase xp gain

WanderingCat27 opened this issue ยท 6 comments

commented

mods like origins-classes and bewitchment which have options to get 2x xp (or combined 4x when using both magicians and the demon contract) mess with the xp pickup for the graves since it drops on the ground. Maybe doing something similar to the /xp command and instead of dropping the levels giving the levels to the person that breaks it could fix it (whether as a config or feature) it could also be good when like picking up grave near ppl not worrying about ur xp getting picked up by them

This basically means if I have xp percentage above 25% players can exponentially increase their xp by dying (and have done so to get like 500 levels)

commented

This could be exploited either way, since graves drop XP after decaying. Ideally you can disable keeping XP or lock it to 25%

commented

This could be exploited either way, since graves drop XP after decaying. Ideally you can disable keeping XP or lock it to 25%

I was able to write up smth for it in like 20 min that seems to work. I havent looked at it since making like a week ago, but basically I just forked ur proj and basically I just made my own xp orb class extending xp orb with it's own addExperience method and collide with player (cause thats how both origins and bewitchment seem to do it) and it solves the issue.

commented

That sound like acceptable workaround for me. I will look into that

commented

That sound like acceptable workaround for me. I will look into that

if u have time ofc, it would be appreciated, thx!

commented

That sound like acceptable workaround for me. I will look into that

if u have time ofc, it would be appreciated, thx!

o keep in mind i had planned to go back and actually finish it well so i haphazardly deleted some if statements I remember removing the mending check and I also removed decrement of unknown use (seemed important) but it still worked in barebone testing then I never bothered to look at it again ๐Ÿ‘

commented

Fixed in 2.0.0-rc.1+1.18.1, through you might need to enable it in config! (useAlternativeXPEntity)