[SUGGESTION] Written guide for modders outside of this repository to add to the bestiary
Vetpetmon opened this issue ยท 5 comments
I know this repository doesn't get updated on distribution sites very often, so it may benefit outside modders with their own mob mods to add their own entries into their mod.
I'm attempting to do this on my own end with Wyrms of Nyrus. I'll post any updates and instructions here in this issue thread if it works.
I've made the advancement and patchouli files for a Wyrmling entry, but it doesn't show up.
The patchouli file:
{
"name": "Wyrmling",
"icon": "minecraft:spawn_egg{EntityTag:{id:'wyrmsofnyrus:wyrmling'}}",
"category": "monsters",
"flag": "universalbestiary:entity:wyrmsofnyrus:wyrmling",
"advancement": "universalbestiary:wyrmsofnyrus_wyrmling",
"pages": [
{
"type": "text",
"text": "The $(mob)Wyrmling$() is a misleadingly cute creature that will later grow up into one of many wyrm forms. They're one of the earliest faces seen within the invasion, and can only be found within the $(thing)Hexe Pods$() seen falling from the skies."
},
{
"type": "entity",
"entity": "wyrmsofnyrus:wyrmling",
"text": "Note: Do not trust"
}
]
}
The advancement file:
{
"parent": "universalbestiary:root",
"criteria": {
"unlock": {
"trigger": "universalbestiary:unlock",
"conditions": { "entity": { "type": "wyrmsofnyrus:wyrmling" } }
}
}
}
I am going to attempt a few modifications to the patchouli file to see if there's an issue with the ResourceLocation, and look into this mod's Java code itself to see how UB is behaving.
Hey, I'd like to hear more about how you tested this.
- If it the patchouli book entry or advancement that isn't working, or both?
- If you attempt to give the advancement with a command, does it work? (advancement (grant|revoke) only [])
- Does the entry show up in the book itself, but you just don't see the content of the entry when you attempt to view?
- Do you see any patchouli errors?
Also, I looked through your github and I don't see where you put the patchouli book. It should look like this:
https://github.com/Lykrast/UniversalBestiary/tree/master/src/main/resources/assets/universalbestiary/patchouli_books/bestiary
Also, I looked through your github and I don't see where you put the patchouli book. It should look like this: https://github.com/Lykrast/UniversalBestiary/tree/master/src/main/resources/assets/universalbestiary/patchouli_books/bestiary
It's on the ETB branch, you might be looking at Master (Stable).
The only Patchouli error I'm seeing is Mod patchouli is missing the required element 'version' and a version.properties file could not be found. Falling back to metadata version 1.0-23.6
The game is registering an advancement, the mob identifier does see there's a mob (that part works) but no entry is added to the book. It should be appearing under the "monsters" category, but viewing the whole book index gives no results. I can't tell what part isn't working as nothing is showing up in the log.
I haven't used give advancement commands yet, but I'll go try that out ASAP. I've tried killing and scanning the entity (it can not kill me as it doesn't attack)
Update: No advancement was found by the name 'universalbestiary:wyrmsofnyrus_wyrmling'
I guess it has to be in this repository to work, it seems. You are free to do what you want, the files on ETB are here: https://github.com/Vetpetmon-Labs/Wyrms-of-Nyrus/tree/ETB/src/main/resources/assets/universalbestiary