Unloader

Unloader

8M Downloads

Forge 1.12.2-14.23.2.2647 breaks unloader

evhub opened this issue ยท 4 comments

commented

I updated forge and noticed that unloader seemed to no longer be working, as /forge tps was now showing a bunch of dimensions that didn't used to be there. After a bit of binary search over different forge versions, I think the issue is being caused by forge build 1.12.2-14.23.2.2647, which included the change

bs2609: Check for empty dimensions outside of chunk unloading loop, culling worlds without needing chunk unloads to trigger it. (#4704)

It seems like this change should just replace unloader, but since all the dimensions still show up under /forge tps, the forge change doesn't seem to be doing anything. Thus, an unloader update with compatibility for the new forge version would be greatly appreciated.

commented

Sorry for the delay!

It seems when a dimension is queued to unload, and gets queued again, it resets the wait time.

I actually had this check previously but removed it to make Unloader cross-version compatible. I'll push an update for 1.12.2 with the check back in.

commented

Fixed in commit daf0aa9 for 1.12.2.

You should see it on the Curseforge page soon.

Again, sorry for the delay!

commented

Doesn't seem to be working on our server with forge-1.12.2-14.23.3.2678. Any way to check if its trying do do anything?

commented

Fixed for real now. 90832b4