Utilitarian

Utilitarian

Mods
11M Downloads

noStartupMessagesMessages blocking any message containing the word "alpha"

AlphaConqueror opened this issue ยท 2 comments

commented

utilitarian/src/main/java/cy/jdkdigital/utilitarian/event/EventHandler.java

Lines 134 to 143 in dbe6bd8

public static void onSystemMessage(ClientChatReceivedEvent.System event) {
if (Config.NO_STARTUP_MESSAGES_ENABLED.get()) {
Config.NO_STARTUP_MESSAGES_MESSAGE_STRINGS.get().forEach(s -> {
if (event.getMessage().getString().contains(s)) {
Utilitarian.LOGGER.debug("Blocked message: \"" + event.getMessage().getString() + "\"");
event.setCanceled(true);
}
});
}
}

I don't think there is a reason to block any and every message containing the word "alpha". This seems more like a band-aid solution to a problem than an actual solution.

Proposed changes:

  • Disable by default.
  • Let servers handle it. (Since I do not know why this was even implemented (git blame was not helpful), this might not be possible.)
  • Use more a more concrete string or regular expression approach to filter out the messages you actually want to filter out, and avoid using String#contains.
commented

I'm sorry, I got confused. I guess the FTB people cut down the original string to just "alpha" as a band-aid solution, which is causing issues on the server side. Thanks for the quick response.