Valhelsia Structures

Valhelsia Structures

21M Downloads

Small Dungeon structure spawns weird, filled with stone and water . Is it not filled with air blocks?

BugmanBugman opened this issue · 8 comments

commented

2020-10-14_16 20 29
2020-10-14_16 20 32
2020-10-14_16 20 37
2020-10-14_16 20 55

commented

2020-10-14_16 46 38
2020-10-14_16 46 36
2020-10-14_16 46 29
Nvm, I don't think it's YUNG's. The small dungeon structure seems borked in general. I tested it without YUNGs and it was still filled with stone and water.

commented

Please let us know which version of the mod you are using, which Forge version, and a list of other mods installed (with versions). I can't begin to troubleshoot when I don't even know if you're playing Minecraft 1.14.4, 1.15.2, 1.16.1, or 1.16.3, all of which have that dungeon.

commented

My bad, it’s 1.16.3 and the forge version was 34.1.23

I can’t get a comprehensive list of my mods rn, but when I get on tmrw I can do some binary searching to see if it’s a mod compat issue

commented

Your logs contain a list of your mods and a lot of other helpful information. Please reply and drag and drop your log file into the reply.

commented

debug.log
latest.log
Not sure if that would help, I just tested the mod by itself and the small dungeon structure was still filled with stone and water. It seems to be borked naturally, maybe it wasn't saved right?
2020-10-19_14 47 52
2020-10-19_14 48 02
2020-10-19_14 47 26
2020-10-19_14 47 32
I don't believe the structure is supposed to look like this according to the trailer.

commented

Yeah can confirm.

My suspicion is that it is this method:

newList.add(Pair.of(JigsawPiece.func_242851_a (ValhelsiaStructures.MOD_ID + ":" + pair.getFirst(), new StructureProcessorList(processorList)), pair.getSecond()));

JigsawPiece.func_242849_a is the same as using "minecraft:legacy_single_pool_element" for template pool json files.
It's for pillager outposts and villages which are older jigsaw structures and are setup in a certain way. Now what I believe you should be doing just for the dungeon is JigsawPiece.func_242861_b as this is "minecraft:single_pool_element" for template pool json files.

Their is a slight difference in Air/Structure Void behavior I found and it has tripped me up too. So give JigsawPiece.func_242861_b a try with the dungeon as when I spawned the dungeon piece myself by Structure Blocks, it did replace the stone with air properly which is why I thought about this weird edge case thing.

commented

@TelepathicGrunt Thanks for that insight. I've let the 1.16.3 developer know. Much appreciated. :)

commented

Problem fixed in the latest version (16.0.5).