Describe the bug

When removing a dependency mod(like mantle) for tinkers construct , i got crash from java.lang.NoClassDefFoundError: net/minecraft/client/model/ModelRenderer

Reproducibility

Please try to reproduce the issue with as few other mods as possible. Then check one of the following checkboxes according to your results. To check a checkbox, replace the space between the square brackets with an x (like this [x]) or create the issue and check the checkbox by clicking on it.

• I reproduced this issue with as few other mods as possible installed.
• I am unable to reproduce this issue consistently.

To Reproduce

Steps to reproduce the behavior:

1. install tinkers construct + valkyrie + dependenies
2. remove mantle
3. launch game
4. crash on startup

Expected behavior

don't crash and just make a screen for mods errors

Screenshots or/and videos

valkyrie enabled :

crash

valkyrie disabled :

Logs or/and crash reports

https://mclo.gs/YPm6DQR

Versions

• Valyrie version : 0.1.3
• Forge: 1.12.2 - 14.23.5.2860
• Java: jdk8.0.372
• Java JVM: Zulu

Specification:

• OS: Windows 10
• CPU: I5-10400F
• GPU: RTX 3060
• RAM Allocated: 12417mb

All of these info below are not necessary but may become necessary depending on the issue

• CPU Speed: 2.9GHz Boost around 4.3Ghz]
• CPU Core: 6
• CPU Threads: 12
• RAM Size: 32GB
• RAM Speed: 2666MHz
• Storage Type: 1 TO SSD KINGTON
• GPU VRAM: 12 GB

Does adding a ! at the start of the Red Core file name fixes the issue, for example if you are using Red-Core-0.3.1.jar rename it to !Red-Core-0.3.1.jar

yes i get the same crash with !Red-Core-0.3.1.jar

Judging from that behavior, I would guess that the Mantle mixin is still being loaded even though you check for it due to some sort of difference in MixinBooter 8. I believe UT had the same way of loading the mixins conditionally as your mod and was resolved with this. All of the mixins for this mod are also configured to be defaultRequire: 1, so makes sense this would hard crash instead of error and ignore the mixin.

Judging from that behavior, I would guess that the Mantle mixin is still being loaded even though you check for it due to some sort of difference in MixinBooter 8. I believe UT had the same way of loading the mixins conditionally as your mod and was resolved with this.

As it turned out, this was just me messing up the default switch cases though. 😉

Oh you're right, took a bit to understand what that fix was about. Disregard what I suggested!

I already know how to fix the issue just need to actually do it, the issue is that when the missing mod screen pops up Forge stops loading mods, but Minecraft is still loaded but since Red Core did not load Jafama is not present.
Fixing this is fairly easy though, I just need to make Red Core a core mod (lol) and it should load before anything else

I'm also having a similar issue but instead of ModelRenderer its EntityRenderer. Idk if I should make a separate post or not tho.

I'm also having a similar issue but instead of ModelRenderer its EntityRenderer. Idk if I should make a separate post or not tho.

No it's for the same reasons, should be fixed by Red Core 0.4 when it gets out

Try with Valkyrie Dev 8 and Red Core Dev 3

Dev builds are now released on CurseForge, and archived on Discord.

Valkyrie Dev 8 on CurseForge: https://legacy.curseforge.com/minecraft/mc-mods/valkyrie/files/4683503
Red Core Dev 3 on CurseForge: https://legacy.curseforge.com/minecraft/mc-mods/red-core/files/4683482

fixed