Incompatibility between Valkyrie's precise depth buffer option and Weather mod
ninjakitty844 opened this issue ยท 1 comments
Describe the bug
Weather mod changes how Valkyrie's depth buffer works, and can make your hand able to go through blocks.
Weather mod:
https://www.curseforge.com/minecraft/mc-mods/weather-storms-tornadoes
Requires CoroUtil as dependency:
https://www.curseforge.com/minecraft/mc-mods/coroutil
By default settings, Weather mod just kinda disables Valkyrie's depth buffer. You can get Valkyrie's depth buffer working again by disabling Weather mod's "useEntityRenderHookForShaders" option (in config/CoroUtil/General.cfg), however this will then make your hand able to clip through blocks.
Currently you cant have both precise depth buffer from Valkyrie AND correct hand rendering at the same time, if you are using Weather mod as well.
This is all kind of a mess, but if there is a way to fix this issue from Valkyrie's side somehow, that would be very nice. Maybe if its possible to mixin to Weather mod's code and override the part where it essentially duplicates and forces usage of whatever Minecraft rendering code was lacking a depth buffer? I don't have a good understanding of how this would work, I just really think Weather mod would require depth buffer to look good, the way raindrops immediately become dark blue when over (not under) water breaks immersion a bit :[
Reproducibility
- I reproduced this issue with as few other mods as possible installed.
- I am unable to reproduce this issue consistently.
To Reproduce
Steps to reproduce the behavior:
- Install Valkyrie
- Turn on depth buffer option in Valkyrie's config
- Notice that depth buffer is nice TM
- Install Weather mod
- Notice that your hand clips through blocks now
- Turn off "useEntityRenderHookForShaders" in config/CoroUtil/General.cfg
- Notice that your hand no longer clips through blocks, but now Valkyrie's depth buffer option is non-functional and is doing nothing
Expected behavior
Functional depth buffer from Valkyrie, without hand clipping. And with Weather mod still installed.
Screenshots or/and videos
Clipping hand:
Not clipping hand:
(these images are taken from the exact same position and rotation)
Versions
- Valkyrie: 0.2 Dev 8
- Red Core: 0.4
- Localized Weather & Storms: 1.12.1-2.6.12