Crash while starting (probably cleanroom)
Closed this issue ยท 7 comments
Describe the bug
A clear and concise description of what the bug is.
The game crashes while it is starting up, saying it can't find a "RenderGlobal" class. This possibly is related to CleanroomMC.
Remember that a great explanation leads to a greater understanding
Reproducibility
Please try to reproduce the issue with as few other mods as possible. Then check one of the following checkboxes according to your results. To check a checkbox, replace the space between the square brackets with an x (like this [x]) or create the issue and check the checkbox by clicking on it.
- I reproduced this issue with as few other mods as possible installed.
- I am unable to reproduce this issue consistently.
To Reproduce
Steps to reproduce the behavior:
- Setup CleanroomMC
- Download Valkyrie & Red Core
- Launch the game
(I've also tried with both downloading and not downloading configanytime, mixinbooter, mixincompatability & fugue)
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots or/and videos
If applicable, add screenshots and/or videos to help explain your problem.
Logs or/and crash reports
Versions
- Valkyrie 0.2 (Interestingly, the game will launch fine if on 0.1.3)
- cleanroom-0.2.3
- Java: JDK 21
- Java JVM: Azul
Specification:
- OS: Windows 10
- CPU: Intel(R) Core(TM) i5-4590T CPU @ 2.00GHz
- GPU: NVIDIA GeForce GPU (it literally doesn't say anything else)
- RAM Allocated: 4GB
All of these info below are not necessary but may become necessary depending on the issue
- CPU Speed: [e.g. 3.80GHz Boost around 4.25Ghz]
- CPU Core: [e.g. 8 (Attention Core not logical core)]
- CPU Threads: [e.g. 16 (Named Logical processors in task manager)]
- RAM Size: [e.g. 32GB]
- RAM Speed: [e.g. 2666MHz]
- Storage Type: [HDD or SSD]
- GPU VRAM: [e.g. 2GB]
Most of these information can be found in the task manager
Additional context
Add any other context about the problem here.
Seeing the same issue here (identical crash log) after upgrading to the MixinBooter 10.0 beta.
The only mods I have present are:
- ConfigAnytime 3.0
- MixinBooter 10.0
- Red Core 1.8-1.12 0.6 Dev 7
- Valkyrie 0.2
I'm using the default Minecraft launcher, and I am not using Cleanroom.
Downgrading MixinBooter to version 9.4, or Valkyrie to version 0.1.3, fixes the issue.
Tinkering with this a little bit before going to sleep. Unsure about the root cause at the moment, but changing line 58 of RenderGlobalMixin.java from
@Inject(method = "setupTerrain", at = @At(value = "INVOKE", target = "Lnet/minecraft/profiler/Profiler;startSection(Ljava/lang/String;)V", ordinal = 1, shift = At.Shift.AFTER), locals = LocalCapture.CAPTURE_FAILEXCEPTION)
to
@Inject(method = "setupTerrain", at = @At(value = "INVOKE", target = "Lnet/minecraft/profiler/Profiler;startSection(Ljava/lang/String;)V", ordinal = 1, shift = At.Shift.BY, by = 3), locals = LocalCapture.CAPTURE_FAILEXCEPTION)
fixes the issue, but only in environments where no other mods are injecting into the same method.
RenderLib breaks this solution, but their setupTerrain mixin injects at the head of the method, rather than doing anything offset-based, so one would think it wouldn't impact Valkyrie's at all...? This all seems very strange, but I'm probably missing something silly and obvious.
Incidentally, I did have to downgrade Lombok to version 8.7.1 to get Valkyrie to build at all.
