Valkyrien Skies (Forge/Fabric)

Valkyrien Skies (Forge/Fabric)

5M Downloads

Conflict with Pehkui: Scaled-up player accelerates when sliding against a wall

SIGSTACKFAULT opened this issue ยท 10 comments

commented

Mod Name

Pehkui

This issue occurs when only Valkyrien Skies, addons, and the mod I have specified are installed and no other mods

  • I have tested this issue and it occurs with only Valkyrien Skies, addons, and the mod I have specified

Minecraft Version

1.20.x

Mod Loader

Fabric

Issue description

With Pehkui and Valkyrien Skies, a curious physics bug emerges.

sliding against a wall while holding a directional key and space causes the player to accelerate upwards.

This might actually be a bug in Pehkui.

Recorded a video for you. I would embed it in GitHub but it doesn't like it. https://youtu.be/HIQsreidUMI

Issue reproduction

Export from ATLauncher: Pehkui & Valk conflic test 1.20.1.zip

Logs

latest.log

commented

Also reported as Virtuoel/Pehkui#570. Y'all can figure out which mod's problem it is between yourselves :)

commented

We've heard of similar things happening, which may or may not have been fixed in #927. Were you scaled when this bug occurred?

commented

@thetheaplant it's only when scaled. See the video. it's minorly noticeable at 1.1 scale, but goes really crazy at ~1.3 scale. the link to a modpack i included should:tm: include a world with some commandblocks with the relevant commands so you can test it yourself.

commented

like thea said, #927 should have fixed it, but I don't think the fix is in any public builds

commented

Yep that sounds like the bug i'm experiencing. Can i get a vague ETA on that shipping (next week, next month, etc)?

Sorry it was 1am so i hyperfocused on the "where you scaled" part not the "may or may not have been fixed" part

commented

@SIGSTACKFAULT valkyrien skies isn't getting any released beta builds until VS2.5, which is somewhere between developing and bug fixing.

So probably not soon

commented

Would it be possible to backport #927 to 2.3.0-beta.5? just for myself. I know how to git cherry-pick but have never hacked on a MC mod before

EDIT: to be clear, i'm not asking anyone else to do it. I'm asking if it's possible. And maybe for some hints. The patch seems to apply cleanly but I'm not sure if I need to change a version number or anything

commented

@SIGSTACKFAULT its possible, though you might have to solve a merge conflict or add the code in manually.

Although the code could also just not work on backport, due to api changes

commented

(I'm out of town for the holidays and intellij was still downloading dependencies when I had to leave.)

commented

valkyrienskies-120-2.3.0-beta.5+e4f614ff82.jar.zip

found the compile button. here it is for any future internet travellers, if you're willing to trust a .jar uploaded by a stranger (which you shouldn't, really).