Valkyrien Skies (Forge/Fabric)

Valkyrien Skies (Forge/Fabric)

6M Downloads

Mod STILL causes major memory leak

RubixDude opened this issue ยท 7 comments

commented

This issue occurs when only Valkyrien Skies and addons are installed and no other mods

  • I have tested this issue and it occurs when no other mods are installed

Minecraft Version

1.20.x

Mod Loader

Forge

Issue description

I know it has been fixed multiple times but it seems to have come back, when using the mod, a major memory leak is created, while Garbage Collection can be changed to account for SOME of this, most often it still isn't enough. With a Server with 4 GB of RAM it can take less than 10 minutes to max it out, which I would consider game breaking. Granted, this becomes faster and faster the more the server has to do every tick but it's terrible currently.

Issue reproduction

Install forge 47.4.0
Install VS and Eureka!
Run the game (preferably on a server)
Wait for 10-30 minutes while building one or two bigger ships, it may take longer depending on your system and RNG but look at your memory usage over time and see how it starts to get eaten up.

Logs

I don't have any logs, as my server maxes out on RAM, and then it's hosting provider forcefully shuts it down, without saving anything or crashing anything. I plan on testing this with Spark profiler but I'm having a hard time doing it so if anybody could figure that out and test it, it would be great!

commented

A latest.log should still be generated, please send it.

commented

@thetheaplant Ok, here's the pastebin, hopefully it's related!:
https://pastebin.com/iPA8Rn0k

commented

@thetheaplant FYI this is from a server that has many mods, I could test it with just VS and Eureka if you like, but it'd be a while since it's kinda a pain in my ass to change stuff around

commented

The issue form specifically requires that you make sure the issue occurs with just vs and whatever incompatible mod, if applicable. So yes, please do the bare minimum when making issues.

commented

@thetheaplant Oh I wasn't sure if that was required or not! ๐Ÿ˜… I actually tested and it seems to be stable, I had to reduce the amount of RAM that minecraft is allocated because it uses RAM outside of minecraft, and on a system which is limited (such as a server ran by a hosting service) if you allocate all of the RAM to minecraft it crashes, I would change the mod page and wiki to state that you shouldn't allocate all of your servers available RAM to minecraft as it will break the mod, because most people do, especially with lower end servers, and then you'll get less issues like this one ๐Ÿ˜„ I'll go make a reddit post on how to fix the issues, hopefully it will appear next time someone searches for "VS memory leak" because people (including myself up until now) are still convinced the mod has a memory leak, which it appears to not! :D

commented

How can this be fixed if my server runs on a provider and not from me, myself? I don't think my provider would allow me to change this.

commented

Some providers allow you to change the Java arguments, i dont know why but I'm guessing some plugins or mods require it, I know modrinth (what i use) let's you change it, but I'm not sure about others, normally its in advanced settings or startup arguments :)