Valkyrien Skies (Forge/Fabric)

Valkyrien Skies (Forge/Fabric)

6M Downloads

Light Block block_marker particles not being generated on Valkyrien Skies ships

1101-Grills-Oren opened this issue ยท 0 comments

commented

This issue occurs when only Valkyrien Skies and addons are installed and no other mods

  • I have tested this issue and it occurs when no other mods are installed

Minecraft Version

1.20.x

Mod Loader

Fabric

Issue description

For some reason, only block_marker particles for barriers appear on Valkyrien skies ships. In addition, VS is only checking for barriers, and so that is a mod compatibility issue for when people add custom invis blocks as well.

Reccomended fix: Set it up so that it checks net.minecraft.client.world.ClientWorld::BLOCK_MARKER_ITEMS so that it renders all blocks in that tag, thus fixing the bug with vanilla (then light blocks will render) and mods that modify that variable. Perhaps replace all instances holdingBarrierItem in org.valkyrienskies.mod.mixin.client.world.MixinClientLevel with a list of boolean values? That probably wont entirely fix the problem, but it might help.

Issue reproduction

Make a Valkyrien skies ship. Place a light block on it (minecraft:light). Any blockstate will still reproduce this issue.

Notes: I discovered this bug while making a custom barrier-like block, but this bug still happens with only Valkyrien Skies. I suspect this problem also applies to other versions and Forge versions.

Logs

No response