When I try to add tfcambiental, an addon for TFC, on top of TFC+VS2, the vehicles in VS2 experience bugs.
wglpython opened this issue · 6 comments
This issue occurs when only Valkyrien Skies and addons are installed and no other mods
- I have tested this issue and it occurs when no other mods are installed
Minecraft Version
1.18
Mod Loader
Forge
Issue description
2023-12-08.22-47-40.mp4
When a player stands on a vehicle in VS2, the rendering loading becomes extremely laggy, and it only functions properly when the player is not on the vehicle. I am the developer who previously submitted the compatibility code for TFC and VS2, but this time I can't figure out the cause of the issue.
Issue reproduction
use it
Logs
No response
Can run a Spark profile? https://spark.lucko.me/
That will tell us which parts of the code are running slow.
是否可以运行 Spark 配置文件？https://spark.lucko.me/
这将告诉我们代码的哪些部分运行缓慢。
Its the com.lumintorious.tfcambiental.api.EnvironmentalTemperatureProvider.calculateEnclosure() function thats lagging the server. See the flame graph below, I got it from looking at the spark you posted https://spark.lucko.me/Zfd056Sjnz?hl=12203
Does TFC lag if your player moves very fast in general? I made a mixin to fix calculateEnclosure. Or maybe a newer version of TFCAmbiental broke the mixin and it no longer works? Can you send a log?