Shuts Down Game While Placing Double Slabs
SlavaTalanov opened this issue · 5 comments
Mod Name
Double Slabs (CJMinecraft01)
This issue occurs when only Valkyrien Skies, addons, and the mod I have specified are installed and no other mods
- I have tested this issue and it occurs with only Valkyrien Skies, addons, and the mod I have specified
Minecraft Version
1.19
Mod Loader
Forge
Issue description
VS causes the game to crash when you attempt to place specific slabs with Double Slabs installed. Bizarrely, only some slabs produce the issue.
Issue reproduction
On the latest Forge for 1.19.2, boot up with VS, Kotlin, and Double Slabs (1192-2.2.0.beta3, 3.12.0-all, 1.19-6.1.0).
Load up a world, and get specifically the Cut Copper Slab. There may be other problematic slabs but I haven't tested, but many – like the oxidized variant of the same block – do not produce the issue.
Attempt to place two on top of each other – not even in the vertical configuration, regular slab placement, such that they make a full block.
Message:
The game crashed whilst exception in server tick loop
Error:
org.valkyrienskies.core.impl.util.assertions.stages.Constr
Constraints failed. Stages since last reset: [PRE_TICK,
GET_LAST_TICK_CHANGES, UPDATE_CHUNKS, UPDATE_CHUNKS,
UPDATE_CHUNKS, POST_TICK_START, POST_TICK_GENERATED,
POST_TICK_FINISH, GET_CURRENT_TICK_CHANGES,
CLEAR FOR RESET UPDATE DIMENSIONS, UPDATE PLAYERS ]
Exit: 255
Logs
Does this happen on 1.18? If not, then it already got fixed on 1.18, and 1.19 just hasn't gotten updated yet
This issue is caused because double slabs creates a "world wrapper" object that extends ServerLevel, causing VS to think that a new dimension was added. Since this dimension isn't added during the right stage, the game crashes. We should probably detect new worlds in a different way.
cc @ewoudje
