Render Thread Exception with Distant Horizons
Tamagosci opened this issue ยท 2 comments
Mod Name
Distant Horizons 2.2.1-a
This issue occurs when only Valkyrien Skies, addons, and the mod I have specified are installed and no other mods
- I have tested this issue and it occurs with only Valkyrien Skies, addons, and the mod I have specified
Minecraft Version
1.20.x
Mod Loader
Fabric
Issue description
Loading a ship (moving away and back) which is not near your non-ship spawn point throws an IllegalArgumentException "Received ship create packet for already loaded ship?!" in the render thread, this exception locks the game while displayed, but can be dismissed without the game crashing.
Notably in many cases the ships were already visible when the exception was thrown.
I could not replicate the issue when the latest non-ship spawnpoint is world spawn.
Issue reproduction
Easiest reproduction is:
- Create new world
- /spawnpoint
- move/teleport a significant distance away (ex: 1000 blocks)
- make a ship
- place a bed on the ship and set spawn by right clicking
- respawn (ex: /kill)
Ships built near a land spawnpoint are not consistently affected, but have been affected in some tests.
Logs
I forgot to mention:
- In at least one case the exception was thrown by simply getting closer to an already visible but distant ship.
- Respawning and teleporting cause the issue more consistently than joining a world or walking/flying towards the ship.
- Having the spawnpoint set to a bed on a ship is not required, it simply makes the issue easier to reproduce.
