Vampirism - Become a vampire!

Vampirism - Become a vampire!

16M Downloads

1.19 Update

Cheaterpaul opened this issue ยท 5 comments

commented

TODOS:

  • update to latest forge version
  • check todos. Some things must be checked
  • add vampire forest (works on first world load, but not on loading a created world)
  • check biome data modification
  • vampire spawning somehow do not spawn in other biomes (spawn predicate returns false)
  • add jei integration (jei needs a forge update and updated integration)
  • add guide api integration (guide api needs a forge update)
  • weapon table recipes with potions (swiftness armor)
  • test
commented

Neat.
Questions:

  • Why Java18? Forge seems to be using Java17
  • VampirismRegistries in API seems odd. Can we at least make the public fields final? Isn't there some sort of preferred way for addon mods to obtain registries (optional) registries
commented

Why Java18? Forge seems to be using Java17

Yeah, mixin had some problem with Java 17, but now it is working.

VampirismRegistries in API seems odd. Can we at least make the public fields final? Isn't there some sort of preferred way for addon mods to obtain registries (optional) registries

I moved the registries and deferred registries back to ModRegistries and only kept the RegistryKeys and default forge registry supplier in VampirismRegistries. (Some supplier are required for DefaultSkill/DefaultAction, but this may be solved on another way)

(pushing later today)

commented

We can also think about replacing RefinementSets with Refinement Tags.

commented

Neat. Questions:

  • Why Java18? Forge seems to be using Java17

About Java 18, all i could say is that Java 17 will be LTS until September 2026.

Surelly mojang and Forge will keep Java 17 for so long (Java 18 will not recieve fixes, optimizations or security updates).
Middle versions are unstable versions. Probably you already know about Java LTS versions. Otherwise hope you find this information helpful.

Anyway, thank you for keeping maintenance over this mod.

commented

First release was released