Vampirism - Become a vampire!

Vampirism - Become a vampire!

Mods
16M Downloads

[Bug]: Can`t get a Priest

bakuzan16 opened this issue ยท 2 comments

commented

Minecraft Version

1.19.2

Forge Version

43.2.8

Vampirism Version

1.9.3

Modpack

No response

Singleplayer/Multiplayer

Singleplayer

What happened?

I cant get a single priest villager. Villagers just ignore the altar of cleansing. I am running modpack made by me, but I dont have any villager changing mods. Just Enough Professions see this type of villager and say that altar of cleansing is a workplace, but I still can`t get one, no matter how hard I tried. Before writing this I tried it on superflat world, but still nothing (Screenshot attached).
P. S. Sorry for my bad english

Mods
2023-04-01_09 30 37

Relevant log output

No response

Reproduce steps

  1. Create singleplayer superflat creative world
  2. Load this world
  3. Spawn some villagers
  4. Place some altars of cleansing

Other relevant mods

No response

commented

I'm glad to see that developers have read my bug report and made some changes in code. I'm here because I noticed one other bug, but don't want to create new bug repord. Seems like on this line of code

Vampirism/src/main/java/de/teamlapen/vampirism/core/ModVillage.java

Line 118 in 53b52f2

new VillagerTrades.EmeraldForItems(ModItems.PURE_SALT_WATER.get(), 25, 1, 4),
trade, where you give 25 pure salt water and recieve 1 emerald, but it don`t work so because pure salt water do not stack. Also it is takes a lot of time to make from non-stackable pure salt water holy water. I think this problem is not difficult to solve editing code there

Vampirism/src/main/java/de/teamlapen/vampirism/core/ModItems.java

Line 95 in 53b52f2

public static final RegistryObject<BlessableItem> PURE_SALT_WATER = ITEMS.register("pure_salt_water", () -> new BlessableItem(new Item.Properties().stacksTo(1), HOLY_WATER_BOTTLE_NORMAL::get, HOLY_WATER_BOTTLE_ENHANCED::get) {
, but i thing it will affect some other aspects of game.

P.S If developers don`t notice this I will create a new bug report.

commented

Then we will remove the trade