[Suggestion]: Lower forge version to <47.1.3
Gronglegrowth opened this issue ยท 3 comments
What?
This is not a mod feature request, but it is the closest template I could find.
After Forge 47.1.3, there have been numerous breaking changes and bugs introduced in forge (as a result of merging countless changes without bug-checking, presumably), and many mods as a result have stuck to 47.1.0, or .3 at the highest.
If one were to use the current version (1.9.1-beta2) of vampirism for 1.20 they would have to sacrifice use of many other mods, because it depends on 47.1.21 at minimum. I am requesting you lower the forge version to 47.1.3, at the highest.
If you are unfamiliar with what is going on with forge, which I assume so, consider reading this. A tl;dr is, the forge devs (except for Lexmanos) forked into a new loader. As a result of this, forge versions past the aforementioned 47.1.3 are unreliable, as they are not maintained nor verified by the former devs, only Lexmanos and possibly whomever he has recruited since.
Mod experience
No response
Contributions
No response
Just to add on to this - yes, this does seem to be the case. Forge builds past 47.1.3 have introduced breaking changes due to a lack of proper triage, as the original team has left. TelepathicGrunt has replied under a PR with a picture of currently-detected breaking changes, so I figured I'd refer to it here as well:
Basically, the RB state of 47.1.x isn't very trustworthy anymore, so requiring a higher minimum version might cause unrelated bug reports, unless such versions fix a Vampirism bug from before it.
I am completely aware of the current situation and was holding a RB back in case there was more trouble on the way. But given the current state of Forge #1236.
In Vampirism, the EntityEvent.EyeHeight/EntityEvent.Size event is crucial and must work properly. Unfortunately, this feature is broken starting with Forge 46.1.6. As result, I had to upgrade to a newer Forge version in order to resolve this issue.
I agree that Vampirism should support Forge versions prior to 47.1.6, to allow it to be used alongside other mods that require a prior version or users that do not wish to use newer versions. To achieve this compatibility, Vampirism may need to either remove the feature, specify a version range of [46.1.0,46.1.3], or utilize reflection to support both newer and older forge versions.