Cannot remove blood from blood container, instead getting empty blood bottle
Twisted-Code opened this issue · 17 comments
I can put blood in just fine, but when I try to take it back out, no blood is removed and instead of the bottle filling it becomes a "Blood Bottle" but remains empty. Furthermore you don't seem to have any failsafe code (although you do have a recipe) to turn a Blood Bottle that can't be drank back to a normal one.
So you tried sneaking, but it only converts the bottle and does nothing else?
Maybe another mod is interfering. Can you pls post your log file after trying to fill the bottle and your version of Vampirism? Thx
exactly, and will do. Just let me start Minecraft from scratch so the log isn't quite as massive XD.
this was on a server I set up, but I expect it'll also happen in single player, unless SpongeForge is causing an issue somehow. If I can't get it to happen in singleplayer, I'll also give you the server log, obviously
I couldn't reproduce it, even on the server. Maybe I was doing something wrong, or maybe I removed or updated the conflicting mod. ¯\(ツ)/¯
OK, Can you pls post your log file after trying to fill the bottle and share your version of Vampirism and Forge? Thx
@maxanier I'd like to reopen the issue, as the bug in question is currently happening for me. It seems it might have something to do with trying to fill a blood bottle when I'm already full on hunger, although I can't be sure. I hold shift and right-click on the tank that has blood, but it only converts the bottle, and doesn't fill it
sponge is NOT currently running on the server, as it's currently causing lag spikes and console spam (according to the project's discord staff, causetracker is choking on item drops)
examining the NBT data of my inventory, the resulting blood bottles have neither damage value nor NBT metadata
https://gist.github.com/macks2008/ab23749c233831bc865c3cc0c2360c36
https://gist.github.com/macks2008/9b14ddb41a900ff8e8f3f03a845a4b0b
forge 12.18.3 .2281
vampirism 1.1.0-beta .1
Thanks for the logs.
Unfortunately I'm still unable to find the issue or even reproduce it.
I've created a test version with some verbose logging. Can you please reproduce the issue and then send me the last few (maybe 50) lines of the log (sever side should be sufficient). Thx
https://server1.maxgb.de/s/cZGb530F0y4YzJ6
oh! I found a triggering condition. This seems to happen when I have something in my offhand, like a torch.
Thank you very much :)
I did not mind that an offhand item might interfere.
If holding an item in the offhand (like a torch) disallows block interactions while sneaking even if the main hand item allows it.
Solution is to force block interaction during the block interact event.
Fix will be included in the next release. Many thanks for your investigations.
P.S. Which mod is adding the those task displayed in the pictures you posted?
@maxanier Bailey's Dailies
@maxanier I should also note that this is the only weirdness I've noticed with offhand items. Shift right clicking on the altar of inspiration is also affected. Both hands have to be empty as is, where as it might be possible and perhaps preferable to only require the main hand to be empty.
As far as helping you bug hunt, it was my pleasure. I want the bug fixed about as much as you do :-)