Versions

• Minecraft: 1.12.2
• Forge: 14.23.3.2655
• Vampirism: 1.4.2

Issue Description

I have made an artificial village (following the video to make only 1 spawning cell below) and I'm getting insane amounts (200+) hunters spawning below the platform. I understand that this is probably due to the "size" of the village (48 doors with 16 villagers atm), but still that's quite an insane amount of hunters.

Reproduce Steps

Iron Golem Farm from here in the mining world from Aroma's Dimensional World mod:
https://www.youtube.com/watch?v=xE04Ui90sQY

Additional Information

I'm curious if this is a bug or just an unusual case since it is generating quite a bit of lag. I'm also curious if there is a way to make them not spawn at all or if that would be some sort of feature but I think it would be a good idea to differentiate artificial villages from generated ones.

Damn, I hoped I had resolved this issue.

Somehow the algorithm thinks it needs to spawn more and more hunters. I will investigate this again.

I cannot reproduce it with the world docm offers as download, but I can see a theoretical possibility for this behavior.
I will attempt to change that (even though this is exactly the behavior this type of farm is exploiting with regards to the iron golems.

I understand it's very similar code, but the area in which a iron golem can spawn is fairly small, hunters on the other hand have a massive spawn ranges and don't respect the vanilla "unspawnable" blocks. Also iron golems cap themselves if there is already one present, that's why you have to move them away from the "village", but the hunters don't seem to have a similar mechanic (or at least one that is adequate for their spawn range). These are also contributing to it being hard to deal with.

Could you have it spawn based on if there is a Vampire Hunter building/Vampire Hunter Trainer present in the village?

Hunter spawning is also capped to a limited number in the spawn area. So I guess they are also somehow moved out of the spawning area somehow.
But I will double check to make sure that the area taking into consideration is exactly the same as the spawning area itself. I will also have a look at the "unspawnable" blocks.

The hunter trainer building is not going to help as it is not present in every generated village.

I have decided to completely rewrite the village hunter spawning system as it seems to be non fixable.
Will take some time though #241