Vampire sword attack speed is displayed as 300%
flamechair opened this issue ยท 2 comments
Versions
- Minecraft: 1.12.2
- Forge: 1.12.2 2705
- Vampirism: Vampirism-1.12.2-1.4.2
Issue Description
Vampire sword attack speed registers as 300%
Reproduce Steps
Get vampire sword (either)
Look at attack speed
Additional Information
Not sure if this is intentional or a bug in Forge.
I would guess the latter.
Forge takes the modifier from the sword (e.g. -0.8) and adds the player base value on-top (4). The result is displayed as percent (x100), that's where the 300 comes from.
However, during damage calculation it does 4 + 4*(-0.8) which is either -80% or 20%.
We could create a forge issue for that, but I am not sure if it is worth the trouble.
Relevant code section: ItemStack#getTooltip around line 890 (for 1.12.2)