Vampirism - Become a vampire!

Vampirism - Become a vampire!

16M Downloads

[Bug][1.14.4] Server hard lock - Entities-

ProsperCraft opened this issue ยท 11 comments

commented

Versions

  • Minecraft: 1.14.4
  • Forge: forge-1.14.4-28.1.40
  • Vampirism: Vampirism-1.14.4-1.6.0-alpha+20191006-1207

Issue Description

Server hard lock when players exploring the server, I kept removing mods that showed up in the stacktrace, and was left with this staktrace(acquired with warmroast) that shows Vampirism.
The hard locks started with the addition of vampirism.

Additional Information

2a03421adbdad4c010084371f67b886c

commented

Here is another one.

9c869bae5104d680e74bef8d5766f534

commented

lock.zip

Here are the server logs.

commented

Unfortunately, the warm roast does not really help much.
Some mod (might be Vampirism, might not be) messes up during world gen and locks a chunk.
Then, as soon as a entity is updated in/near it, it causes the dead lock.
The Vampirism creature is just caught in the "crossfire", it just does vanilla stuff.

I went though Vampirism and looked for occasions where it access a chunk (direct or indirect via an Entity), but couldn't not find anything. Furthermore, Vampirism 1.14 has currently hardly any world gen (forest is mostly vanilla) and I cannot reproduce it with just Vampirism (which should theoretically be possible if it causes this issue), I doubt this is caused by Vampirism.

commented

Pls, mention this explanation by gabizou if you open any more issues:
#535 (comment)

commented

Maybe you can try just removing Vampirism from the original modpack, play a couple of hours and then report if the issue still exist. Just to make sure it is actually caused by Vampirism.

commented

Removing Vampirism completely resolved the lock ups.

One on my players had two lockup spots bookmarked and went there more then once locking the server with vampirism, then went there once removed and it no longer locks. Both spots were in vampire forests. Another player said he was in a vampire forest when he locked the server.

commented

Here is the next one, player said he was traveling through a vampire forest.

Removing Vampirism and seeing if we can reproduce.

455431239d8479345abd78efa371dee3

commented

The fix seems to have completely fixed the lockups.

commented

Closing this as it is effectively a duplicate of #535

commented

Perfect ๐Ÿ‘
Thank you for putting in the work and narrowing it down to Vampirism

commented

Looks like we hard locked again, I didn't catch it in time to profile it, here is the watchdog crash

https://gist.github.com/ProsperCraft/73b3fc59f3f97bb9d3c68a5c8dd4421e

Vampirism-1.14.4-1.6.0-alpha+20191011-0002
forge-1.14.4-28.1.40