Vampirism - Become a vampire!

Vampirism - Become a vampire!

Mods
16M Downloads

[Bug] Replenishing Blood from Altar of Inspiration

PendragonII opened this issue ยท 3 comments

commented

Versions

  • Minecraft: 1.12.2
  • Forge: 14.23.5.2844
  • Vampirism: 1.5.5

Issue Description

When having empty blood/glass bottles in the inventory's hotbar while using the Altar of Inspiration, the empty blood/glass bottles will automatically replenish themselves.

Reproduce Steps

  • Open a Minecraft World with creative and cheats enabled, a flat world will do.
  • Become a Level 1 Vampire.
  • Place down and fill an Altar of Inspiration.
  • Throughout your hotbar, place empty blood/glass bottles.
  • Activate the Altar of Inspiration, the empty blood/glass bottles are now replenished.

Additional Information

This bug does not work with the Altar of Infusion nor with level 15. This only affects empty bottles in the hotbar and not the entire inventory.

commented

shit after years someone found out.

Vampirism/src/main/java/de/teamlapen/vampirism/tileentity/TileAltarInspiration.java

Line 102 in e5b1f4f

VampirePlayer.get(ritualPlayer).drinkBlood(100, 0);

Vampirism/src/main/java/de/teamlapen/vampirism/tileentity/TileAltarInspiration.java

Line 114 in e5b1f4f

VampirePlayer.get(ritualPlayer).drinkBlood(Integer.MAX_VALUE, 0, false);

i think the last line must be removed @maxanier

commented

GIF

commented

Rather the first one. The last one deliberately does not fill blood bottles by passing useRemaining=false.
Not sure why the first one even exists.