Vampirism - Become a vampire!

Vampirism - Become a vampire!

16M Downloads

[Bug] rare crash of server during village capture

stepech opened this issue ยท 4 comments

commented

Versions

Issue Description

Upon finishing capturing of the village through its totem, server crashed with error written on client side - saying buffer overflow, and crash-log on server side, shutting whole server down. It must be very rare as we capture villages quite often and this is first time it caused some issue.

Reproduce Steps

Honestly... Idk. Just capture village as a vampire and may be the error will occur, may be not. You can see it in the crash-log attached. The error happened right at the moment when last defender was killed and the village should switch its sides.

There is one more error I just spotted in a client side log, may be it is somehow connected to this one. (Line 271, 305, server crash 496)

Additional Information

Logs

commented

Did the totem worked after a server restart?

commented

This crash seem not possible since Serverworld#onBlockStateChange removes the previous POI data and then sets the new POI
data.
It does not look like we are doing anything wrong.
The only reason i could thing of is a threading issue (the remove POI data would be called after the add POI data Serverworld#onBlockStateChange)

commented

Did the totem worked after a server restart?

It did indeed. It behaves as if nothing happened. It just crashed the server once, but now everything looks normal.

commented

We do not have an idea what could have caused the issue, but apparently it does not occur often and no issue can be found afterwards.
Therefore, I changed the code to not crash the server and just print an error to the log